Merge ~ahasenack/ubuntu/+source/openipmi:xenial-openipmi-ppcarm64-1716517 into ubuntu/+source/openipmi:ubuntu/xenial-devel

Proposed by Andreas Hasenack
Status: Merged
Merge reported by: Andreas Hasenack
Merged at revision: 2ef458dd7175a93cd5d817064ed3e69d43c3d57d
Proposed branch: ~ahasenack/ubuntu/+source/openipmi:xenial-openipmi-ppcarm64-1716517
Merge into: ubuntu/+source/openipmi:ubuntu/xenial-devel
Diff against target: 34 lines (+14/-1)
2 files modified
debian/changelog (+6/-0)
debian/openipmi.init (+8/-1)
Reviewer Review Type Date Requested Status
Christian Ehrhardt  (community) Approve
Canonical Server Pending
Review via email: mp+347837@code.launchpad.net

Description of the change

Sponsoring the fix from Manoj Iyer <email address hidden> for #1716517.

PPA with test packages: https://launchpad.net/~ahasenack/+archive/ubuntu/openipmi-ppcarm64-1716517/+packages (ppa:ahasenack/openipmi-ppcarm64-1716517)

The fix is in debian already.

Unless you have power9 and/or arm64 hardware, this will be difficult to test, other than making sure it doesn't break on other arches like amd64. Otherwise, please refer to bug comments like https://bugs.launchpad.net/ubuntu/+source/openipmi/+bug/1716517/comments/13 to see what was tested.

Basically, starting the service on arm64 or ppc64el fails without this patch because it tries to load an ipmi_si module that won't work on those arches.

To post a comment you must log in.
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

This Xenial upload LGTM

review: Approve
Revision history for this message
Andreas Hasenack (ahasenack) wrote :

Could you also please push the upload tag for me? Then I can dput..

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index ef44b59..ecbb3f7 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,9 @@
6+openipmi (2.0.18-0ubuntu11.2) xenial; urgency=medium
7+
8+ * d/openipmi.init: Fixed openipmi init file for other archs. (LP: #1716517)
9+
10+ -- Manoj Iyer <manoj.iyer@canonical.com> Mon, 21 May 2018 15:50:05 -0500
11+
12 openipmi (2.0.18-0ubuntu11.1) xenial; urgency=medium
13
14 * debian/openipmi.init: add Default-Start and Default-Stop values
15diff --git a/debian/openipmi.init b/debian/openipmi.init
16index 1550680..87ad4df 100644
17--- a/debian/openipmi.init
18+++ b/debian/openipmi.init
19@@ -43,7 +43,14 @@ MODULE_NAME="ipmi"
20 INTF_NUM=0
21
22 IPMI_SMB_MODULE_NAME="ipmi_smb"
23-IPMI_SI_MODULE_NAME="ipmi_si"
24+case $(uname -m) in
25+ "aarch64")
26+ IPMI_SI_MODULE_NAME="ipmi_ssif" ;;
27+ "ppc64le")
28+ IPMI_SI_MODULE_NAME="ipmi_powernv" ;;
29+ *)
30+ IPMI_SI_MODULE_NAME="ipmi_si" ;;
31+esac
32 kernel=`uname -r | cut -d. -f1-2`
33 if [ "${kernel}" == "2.4" ]; then
34 IPMI_SMB_MODULE_NAME="ipmi_smb_intf"

Subscribers

People subscribed via source and target branches