Merge ~ahasenack/ubuntu/+source/mariadb-10.6:kinetic-mariadb-uring-memlock into ubuntu/+source/mariadb-10.6:ubuntu/devel

[Andreas Hasenack]

Disable lto to fix catching the exception that is thrown when mariadb tries to setup uring and it can't lock enough memory due to a low MEMLOCK limit.

For some reason, the exception isn't caught when lto is enabled, and mariadb crashes with sigabort instead. Upstream is wondering if it's a compiler bug.

Normally universe packages get this fix via an added entry in the lto-disabled-package, but I plan to SRU this to jammy, and the SRU fix will have to be disabling lto in the mariadb package itself, so I'm applying the same method for the development release.

I still have to write up the SRU template, and create jammy packages. PPAs are unusable atm.

PPA at https://launchpad.net/~ahasenack/+archive/ubuntu/mariadb-uring-memlock/+packages, but the build hasn't even started yet.

To test the existence of the bug, these steps are sufficient:
- create a focal VM
- confirm ulimit -l value in that VM. I've been getting the value "64", but anything lower than 256 will trigger the bug.
- inside that VM, create a jammy LXD
- iside that LXD, install mariadb-server. It will fail.

The mariadb build takes a long time. With 12 cores, about 1h, so I suggest to wait for the ppa. Or not :)

I'm unsure what the jammy SRU version will be. Current state is:
 mariadb-10.6 | 1:10.6.7-2ubuntu1 | jammy/universe | source
 mariadb-10.6 | 1:10.6.7-2ubuntu1 | kinetic/universe | source
 mariadb-10.6 | 1:10.6.7-3 | jammy-proposed/universe | source
 mariadb-10.6 | 1:10.6.7-3 | kinetic-proposed/universe | source

I don't know if the 10.6.7-3 jammy-proposed upload will be removed. I'll ask around.

[Sergio Durigan Junior (sergiodj)]

Thanks, Andreas.

This makes sense to me, and I agree with the workaround. Unfortunately these LTO bugs are very hard to diagnose... Daniel Black did a good job investigating it.

Regarding the version, I think 1:10.6.7-3 has been removed from jammy-proposed because I don't see it there anymore. So your upload should be versioned 1:10.6.7-2ubuntu1.1.

LGTM with this change.

review: Approve

[Andreas Hasenack (ahasenack)]

Version 10.6.7-3 are still in proposed:

$ rmadison mariadb-10.6
 mariadb-10.6 | 1:10.6.7-2ubuntu1 | jammy/universe | source
 mariadb-10.6 | 1:10.6.7-2ubuntu1 | kinetic/universe | source
 mariadb-10.6 | 1:10.6.7-3 | jammy-proposed/universe | source
 mariadb-10.6 | 1:10.6.7-3 | kinetic-proposed/universe | source

I'll keep kinetic at 10.6.7-3u1, jammy we'll see.

[Andreas Hasenack (ahasenack)]

Hah, my d/changelog had jammy in it, no wonder you mentioned it :)

[Sergio Durigan Junior (sergiodj)]

Ah, right! Sorry, I thought this MP was targeting Jammy. Now I understand why you appended "ubuntu1"...

BTW, I still don't see the package in jammy-proposed:

$ rmadison mariadb-10.6
ubuntu:
 mariadb-10.6 | 1:10.6.7-2ubuntu1 | jammy/universe | source
 mariadb-10.6 | 1:10.6.7-2ubuntu1 | kinetic/universe | source
 mariadb-10.6 | 1:10.6.7-3 | kinetic-proposed/universe | source

[Sergio Durigan Junior (sergiodj)]

I don't see it here either:

https://launchpad.net/ubuntu/+source/mariadb-10.6

[Andreas Hasenack (ahasenack)]

It failed to build, there is something going on with boost in kinetic. I will let it settle over the weekend and retry later.

[Andreas Hasenack (ahasenack)]

Ah, the jammy upload is in unapproved. I asked in #ubuntu-release for it to be deleted.

diff --git a/debian/changelog b/debian/changelog
index 3e311ff..e000cf0 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,9 @@
+mariadb-10.6 (1:10.6.7-3ubuntu1) kinetic; urgency=medium
+
+  * d/rules: disable LTO (LP: #1970634)
+
+ -- Andreas Hasenack <[e-mail]>  Fri, 29 Apr 2022 09:30:44 -0300
+
 mariadb-10.6 (1:10.6.7-3) unstable; urgency=medium
 
   * Fix syntax error in unstable tests lists
diff --git a/debian/control b/debian/control
index 9d92ac0..e57bce5 100644
--- a/debian/control
+++ b/debian/control
@@ -1,7 +1,8 @@
 Source: mariadb-10.6
 Section: database
 Priority: optional
-Maintainer: Debian MySQL Maintainers <[e-mail]>
+Maintainer: Ubuntu Developers <[e-mail]>
+XSBC-Original-Maintainer: Debian MySQL Maintainers <[e-mail]>
 Uploaders: Otto Kekäläinen <[e-mail]>
 Build-Depends: bison,
                cmake,
diff --git a/debian/rules b/debian/rules
index 6d02cc0..2ff2e3b 100755
--- a/debian/rules
+++ b/debian/rules
@@ -3,6 +3,10 @@
 # Enable Debian Hardening
 # https://wiki.debian.org/Hardening
 export DEB_BUILD_MAINT_OPTIONS = hardening=+all
+
+# Disable LTO, see LP: #1970634
+export DEB_BUILD_MAINT_OPTIONS=optimize=-lto
+
 DPKG_EXPORT_BUILDFLAGS = 1
 # Include all defaults, including buildflags.mk
 include /usr/share/dpkg/default.mk