Merge ~ahasenack/ubuntu/+source/libseccomp:noble-dep8-skip-armhf-lxd-ubuntu into ubuntu/+source/libseccomp:ubuntu/devel

[Andreas Hasenack]

Skip the testsuite-live-python3 test if:
- on ubuntu
- on armhf
- on container

The armhf container used in DEP8 tests in Ubuntu doesn't work well with this testsuite. The check that debian added to skip this test if seccomp filtering is already applied determines that there is no seccomp filtering in the ubuntu case, and the test proceeds, but it fails anyway. In debian it's being skipped. I tried troubleshooting this a while, but this became a rabbit hole, so I think this is the simplest workaround for now. This test wasn't being run in the past anyway, because it was flagged as isolation-machine, so it never ran in our armhf infra (nor in debian's).

PPA with amd64 and armhf: https://launchpad.net/~ahasenack/+archive/ubuntu/libseccomp-dep8-fix/

DEP8: green, showing testsuite-live-python3 was skipped on armhf:
305s autopkgtest [12:32:34]: test testsuite-live-python3: [-----------------------
307s Building scmp_api_level ...
307s Building scmp_arch_detect ...
307s Building scmp_sys_resolver ...
308s WARNING: Skipping this test on Ubuntu armhf LXD.
308s The way armhf LXD containers are setup prevents the test from completing.
308s See LP: #2051118 for details.
308s autopkgtest [12:32:37]: test testsuite-live-python3: -----------------------]
311s testsuite-live-python3 SKIP exit status 77 and marked as skippable

[Bryce Harrington (bryce)]

LGTM, +1

I hadn't run across dpkg-vendor before, I may have to steal this technique for some of my armhf test flakers.

review: Approve

[git-ubuntu bot (git-ubuntu-bot)]

Approvers: ahasenack, bryce
Uploaders: ahasenack, bryce
MP auto-approved

review: Approve

[Andreas Hasenack (ahasenack)]

Thanks, uploaded

Uploading libseccomp_2.5.4-2ubuntu2.dsc
Uploading libseccomp_2.5.4-2ubuntu2.debian.tar.xz
Uploading libseccomp_2.5.4-2ubuntu2_source.buildinfo
Uploading libseccomp_2.5.4-2ubuntu2_source.changes

diff --git a/debian/changelog b/debian/changelog
index f277627..15501d3 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,10 @@
+libseccomp (2.5.4-2ubuntu2) noble; urgency=medium
+
+  * d/t/testsuite-live-python3: skip this test if on a) armhf; b)
+    ubuntu; c) lxd (LP: #2051118)
+
+ -- Andreas Hasenack <[e-mail]>  Fri, 26 Jan 2024 15:04:52 -0300
+
 libseccomp (2.5.4-2ubuntu1) noble; urgency=medium
 
   * Merge with Debian; remaining changes:
diff --git a/debian/tests/testsuite-live-python3 b/debian/tests/testsuite-live-python3
index f4fb094..a4311f7 100644
--- a/debian/tests/testsuite-live-python3
+++ b/debian/tests/testsuite-live-python3
@@ -4,6 +4,17 @@ set -eu
 
 . debian/tests/common
 
+arch=$(dpkg --print-architecture)
+vendor=$(dpkg-vendor --query Vendor)
+if [ "${arch}" = "armhf" ] && [ "${vendor}" = "Ubuntu" ]; then
+    if systemd-detect-virt --container > /dev/null; then
+        echo "WARNING: Skipping this test on Ubuntu armhf LXD."
+        echo "The way armhf LXD containers are setup prevents the test from completing."
+        echo "See LP: #2051118 for details."
+        exit 77
+    fi
+fi
+
 # make sure "python" points to python3 as this is not configurable
 # in the regression script
 mkdir python3env