Merge ~ahasenack/ubuntu/+source/krb5:focal-krb5-i386-deps into ubuntu/+source/krb5:ubuntu/devel

Proposed by Andreas Hasenack
Status: Merged
Approved by: Andreas Hasenack
Approved revision: 799f547fc9df5f88de0256beb3ce292a52b53cc8
Merged at revision: 799f547fc9df5f88de0256beb3ce292a52b53cc8
Proposed branch: ~ahasenack/ubuntu/+source/krb5:focal-krb5-i386-deps
Merge into: ubuntu/+source/krb5:ubuntu/devel
Diff against target: 40 lines (+13/-1)
2 files modified
debian/changelog (+10/-0)
debian/control (+3/-1)
Reviewer Review Type Date Requested Status
Christian Ehrhardt  (community) Approve
Canonical Server Pending
Review via email: mp+377111@code.launchpad.net

Description of the change

As seen on http://autopkgtest.ubuntu.com/packages/krb5/focal/i386

specifically:
  Depends: krb5-doc:i386 but it is not installable

Make krb5-doc:i386 installable on amd64

Test on an amd64 host:

sudo dpkg --add-architecture i386
sudo apt update
sudo apt install krb5-doc:i386

Without the fix, the above fails like this:
Package krb5-doc:i386 is not available, but is referred to by another package.
This may mean that the package is missing, has been obsoleted, or
is only available from another source

E: Package 'krb5-doc:i386' has no installation candidate

With the fix it installs normally. A better test would be to apt install --install-suggests something like krb5-multidev:i386, but that will fail unless https://code.launchpad.net/~ahasenack/ubuntu/+source/kerberos-configs/+git/kerberos-configs/+merge/377110 is landed already, so the above is a simpler test case.

I'll proposed this for debian as well, and update this MP once I have that info.

For reference: https://wiki.ubuntu.com/MultiarchCross

To post a comment you must log in.
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

I'd like if we could add a link to https://lists.ubuntu.com/archives/ubuntu-devel/2019-December/040859.html to the changelog or the d/control to help people finding the reasoning for this.

Since this is Ubuntu only I'm not sure if we can submit that to Debian before they remove i386.
Do you think we can?

The change itself LGTM and I'm +1 on the upload with the link above added.

review: Approve
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

wait - no update maintainer?

review: Needs Fixing
Revision history for this message
Andreas Hasenack (ahasenack) wrote :

ups

Revision history for this message
Andreas Hasenack (ahasenack) wrote :
Revision history for this message
Andreas Hasenack (ahasenack) wrote :

krb5 is now an ftbfs in focal due to the python2 changes:
The following packages have unmet dependencies:
 builddeps:./ : Depends: python but it is not going to be installed
                Depends: python-sphinx but it is not going to be installed
                Depends: doxygen-latex but it is not going to be installed
E: Unable to correct problems, you have held broken packages.

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

+1 after update-metadata was added

review: Approve
Revision history for this message
Andreas Hasenack (ahasenack) wrote :

krb5 builds fine now, I'll upload.

Tagging and uploading 799f547fc9df5f88de0256beb3ce292a52b53cc8

$ git push pkg upload/1.17-6ubuntu1
Enumerating objects: 17, done.
Counting objects: 100% (17/17), done.
Delta compression using up to 4 threads
Compressing objects: 100% (13/13), done.
Writing objects: 100% (13/13), 1.76 KiB | 69.00 KiB/s, done.
Total 13 (delta 9), reused 0 (delta 0)
To ssh://git.launchpad.net/~usd-import-team/ubuntu/+source/krb5
 * [new tag] upload/1.17-6ubuntu1 -> upload/1.17-6ubuntu1

$ dput ubuntu ../krb5_1.17-6ubuntu1_source.changes
Checking signature on .changes
gpg: ../krb5_1.17-6ubuntu1_source.changes: Valid signature from AC983EB5BF6BCBA9
Checking signature on .dsc
gpg: ../krb5_1.17-6ubuntu1.dsc: Valid signature from AC983EB5BF6BCBA9
Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading krb5_1.17-6ubuntu1.dsc: done.
  Uploading krb5_1.17-6ubuntu1.debian.tar.xz: done.
  Uploading krb5_1.17-6ubuntu1_source.buildinfo: done.
  Uploading krb5_1.17-6ubuntu1_source.changes: done.
Successfully uploaded packages.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 81b877a..2d25e93 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,13 @@
6+krb5 (1.17-6ubuntu1) focal; urgency=medium
7+
8+ * d/control: add "Multi-Arch: foreign" to allow krb5-doc to be used as
9+ a dependency of architecture-dependent packages. In particular, this
10+ lets krb5-doc:i386 be installed on an amd64 host. See
11+ https://lists.ubuntu.com/archives/ubuntu-devel/2019-December/040859.html
12+ for details.
13+
14+ -- Andreas Hasenack <andreas@canonical.com> Mon, 06 Jan 2020 16:24:39 -0300
15+
16 krb5 (1.17-6) unstable; urgency=medium
17
18 * Stop depending on texlive-generic-extra, which is no longer built,
19diff --git a/debian/control b/debian/control
20index f78fa16..9e8758c 100644
21--- a/debian/control
22+++ b/debian/control
23@@ -8,7 +8,8 @@ Build-Depends: debhelper (>= 10), byacc | bison,
24 libverto-dev (>= 0.2.4), pkg-config
25 Build-Depends-Indep: python, python-cheetah, python-lxml, python-sphinx, doxygen, doxygen-latex
26 Standards-Version: 4.1.1
27-Maintainer: Sam Hartman <hartmans@debian.org>
28+Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
29+XSBC-Original-Maintainer: Sam Hartman <hartmans@debian.org>
30 Uploaders: Russ Allbery <rra@debian.org>, Benjamin Kaduk <kaduk@mit.edu>
31 Homepage: http://web.mit.edu/kerberos/
32 VCS-Git: https://salsa.debian.org/debian/krb5
33@@ -235,6 +236,7 @@ Description: TLS plugin for MIT Kerberos
34
35 Package: krb5-doc
36 Architecture: all
37+Multi-Arch: foreign
38 Conflicts: heimdal-docs
39 Section: doc
40 Depends: ${misc:Depends}

Subscribers

People subscribed via source and target branches