Merge ~ahasenack/ubuntu/+source/ipmitool:disco-segfault-1817307 into ubuntu/+source/ipmitool:ubuntu/devel
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Andreas Hasenack | ||||
Approved revision: | 5ba32b6586a15ceec83696dc55327476408b573c | ||||
Merged at revision: | 5ba32b6586a15ceec83696dc55327476408b573c | ||||
Proposed branch: | ~ahasenack/ubuntu/+source/ipmitool:disco-segfault-1817307 | ||||
Merge into: | ubuntu/+source/ipmitool:ubuntu/devel | ||||
Diff against target: |
91 lines (+57/-1) 4 files modified
debian/changelog (+7/-0) debian/control (+2/-1) debian/patches/0130-fix-segfault.patch (+47/-0) debian/patches/series (+1/-0) |
||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Andreas Hasenack | Approve | ||
Christian Ehrhardt (community) | Needs Fixing | ||
Review via email: mp+363810@code.launchpad.net |
Description of the change
Patch found in upstream's git repo, and confirmed by the reporter to fix the segfault. I don't have a way to reproduce it atm, though.
Reporter will try other releases. Based on the version, it should at least happen in bionic as well. I will prepare branches for those once this lands, and if we get confirmation of the problem in the other ubuntu releases.
The upstream patch applies with offset, but I checked and the change is inserted in the correct places. Because of that I chose to not refresh the patch and keep it like it was committed upstream. If you prefer, however, I can refresh it and use our normal full DEP3 header instead of the github "add .patch to the url" trick.
Generally LGTM, but one thing - the patch has no dep-3 headers at all.
It is just the upstream patch as is.
Once that is fixed feel free to self-approve and upload as the rest really is ok.
Furthermore since they seem to release [1] rareley or lets call it sporadic let us bother Manoj to also report that to Debian.
[1]: https:/ /github. com/pjdhpe/ ipmitool/ releases