Merge ~ahasenack/ubuntu/+source/golang-github-fsouza-go-dockerclient:groovy-missing-bd-1883960 into ubuntu/+source/golang-github-fsouza-go-dockerclient:ubuntu/devel

[Andreas Hasenack]

Add a missing build dependency. The FTBFS doesn't happen in Debian, and I think the b-d comes via golang-github-docker-docker-dev which in the ubuntu case has shockingly just one depends, whereas in debian it has dozens. I filed bug #1883978 to investigate that.

Without this b-d, golang tries to fetch it at buildtime, and that fails in the launchpad builders.

I don't think it makes sense to push this to debian until bug #1883978 is further investigated. That being said, debian may have just gotten lucky, as the patch that introduced the requirement for this module in a previous upload (http://paste.ubuntu.com/p/23vMxTBWCV/) should have added the b-d.

The debian build logs (https://buildd.debian.org/status/fetch.php?pkg=golang-github-fsouza-go-dockerclient&arch=all&ver=1.6.5-1&stamp=1591875198&raw=0) show that golang-golang-x-crypto-dev was installed, so it's also not a case of the debian builders being generous with internet access during build.

PPA: https://launchpad.net/~ahasenack/+archive/ubuntu/fsouza/

[Michael Hudson-Doyle (mwhudson)]

makes sense

review: Approve

[Bryce Harrington (bryce)]

* Changelog:
  - [√] old content and logical tag match as expected
  - [√] changelog entry correct version and targeted codename
  - [√] changelog entries correct
  - [√] update-maintainer has been run

* Actual changes:
  - [-] no upstream changes to consider
  - [-] no further upstream version to consider
  - [√] debian changes look safe

* Old Delta:
  - [-] dropped changes are ok to be dropped
  - [-] nothing else to drop
  - [-] changes forwarded upstream/debian (if appropriate)

* New Delta:
  - [√] no new patches added
  - [-] patches match what was proposed upstream
  - [-] patches correctly included in debian/patches/series
  - [-] patches have correct DEP3 metadata

* Build/Test:
  - [ ] build is ok
  - [ ] verified PPA package installs/uninstalls
  - [ ] autopkgtest against the PPA package passes
  - [ ] sanity checks test fine

I didn't check build or autopkgtests since this is a FTBS already so if it doesn't build it'll be evident (and not a regression).

LGTM, +1

review: Approve

[Andreas Hasenack (ahasenack)]

Thanks, tagging and uploading 6fe546db329479adf1a3a61fcbe082b72db244a0

$ git push pkg upload/1.6.5-1ubuntu1
Enumerating objects: 17, done.
Counting objects: 100% (17/17), done.
Delta compression using up to 4 threads
Compressing objects: 100% (13/13), done.
Writing objects: 100% (13/13), 1.45 KiB | 1.45 MiB/s, done.
Total 13 (delta 9), reused 0 (delta 0)
To ssh://git.launchpad.net/ubuntu/+source/golang-github-fsouza-go-dockerclient
 * [new tag] upload/1.6.5-1ubuntu1 -> upload/1.6.5-1ubuntu1

$ dput ubuntu ../golang-github-fsouza-go-dockerclient_1.6.5-1ubuntu1_source.changes
Checking signature on .changes
gpg: ../golang-github-fsouza-go-dockerclient_1.6.5-1ubuntu1_source.changes: Valid signature from AC983EB5BF6BCBA9
Checking signature on .dsc
gpg: ../golang-github-fsouza-go-dockerclient_1.6.5-1ubuntu1.dsc: Valid signature from AC983EB5BF6BCBA9
Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading golang-github-fsouza-go-dockerclient_1.6.5-1ubuntu1.dsc: done.
  Uploading golang-github-fsouza-go-dockerclient_1.6.5-1ubuntu1.debian.tar.xz: done.
  Uploading golang-github-fsouza-go-dockerclient_1.6.5-1ubuntu1_source.buildinfo: done.
  Uploading golang-github-fsouza-go-dockerclient_1.6.5-1ubuntu1_source.changes: done.
Successfully uploaded packages.

diff --git a/debian/changelog b/debian/changelog
index 7fffbf7..3f6dae5 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,10 @@
+golang-github-fsouza-go-dockerclient (1.6.5-1ubuntu1) groovy; urgency=medium
+
+  * d/control: add missing golang-golang-x-crypto-dev build-dependency,
+    needed for build-time tests (LP: #1883960)
+
+ -- Andreas Hasenack <[e-mail]>  Wed, 17 Jun 2020 18:24:47 -0300
+
 golang-github-fsouza-go-dockerclient (1.6.5-1) unstable; urgency=medium
 
   [ Debian Janitor ]
diff --git a/debian/control b/debian/control
index 0d08a7b..58d8896 100644
--- a/debian/control
+++ b/debian/control
@@ -2,7 +2,8 @@ Source: golang-github-fsouza-go-dockerclient
 Section: devel
 Priority: optional
 Standards-Version: 4.5.0
-Maintainer: pkg-go <[e-mail]>
+Maintainer: Ubuntu Developers <[e-mail]>
+XSBC-Original-Maintainer: pkg-go <[e-mail]>
 Uploaders: Dmitry Smirnov <[e-mail]>
 Build-Depends: debhelper-compat (= 12),
     dh-golang,
@@ -15,6 +16,7 @@ Build-Depends: debhelper-compat (= 12),
 #   golang-github-opencontainers-runc-dev,
     golang-github-sirupsen-logrus-dev,
     golang-github-stretchr-testify-dev,
+    golang-golang-x-crypto-dev,
     golang-golang-x-net-dev,
     golang-golang-x-sys-dev,
 Homepage: https://github.com/fsouza/go-dockerclient