Merge ~ahasenack/ubuntu/+source/freeipa:disco-freeipa-restrict-dep8-packages into ubuntu/+source/freeipa:ubuntu/devel
Status: | Rejected |
---|---|
Rejected by: | Christian Ehrhardt |
Proposed branch: | ~ahasenack/ubuntu/+source/freeipa:disco-freeipa-restrict-dep8-packages |
Merge into: | ubuntu/+source/freeipa:ubuntu/devel |
Diff against target: |
29 lines (+10/-1) 2 files modified
debian/changelog (+8/-0) debian/tests/control (+2/-1) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Christian Ehrhardt (community) | Disapprove | ||
Canonical Server Core Reviewers | Pending | ||
Review via email: mp+360062@code.launchpad.net |
Description of the change
freeipa dep8 tests are currently blocking the samba migration (update, see comment: also blocking sssd) because they found what we think is a real bug in samba, but entirely by accident. The dep8 tests don't even run. The bug happens when winbind and samba are installed together, and winbind is started before sambe. In this case, samba will fail to start.
Upstream bug is https:/
The idea behind this branch is to workaround that bug by not installing winbind, as it's not needed for the freeipa tests. It's currently pulled in by freeipa-
That indeed is enough to let the dep8 freeipa tests run again, but then the 4.7.1-1 upload of freeipa added a change to ignore test failures:
* tests: Don't fail the tests, just dump the log if something goes
wrong.
I removed that and ran the tests, and they are indeed failing, but for other, more complicated (java) reasons:
<ahasenack> Caused by: java.lang.
<ahasenack> does that ring a bell?
<tjaalton> where's this from?
<ahasenack> tjaalton: /var/log/
<tjaalton> ah, you have the fresh libjss-java?
<ahasenack> tjaalton: the test run fails like this: https:/
<tjaalton> which builds with jdk11 now
<ahasenack> tjaalton: it's disco, I might
<tjaalton> 4.5.1-1
<ahasenack> yes, that one
<tjaalton> dogtag itself needs to be fixed, it'll take a while until new resteasy3.0 with jackson2 provider is available (just uploaded it)
<tjaalton> after that dogtag 10.6.8 should be fine, and I've fixed it to build with jdk11
<tjaalton> now checking resteasy 3.6.2 if it can replace src:resteasy3.0..
So, the summary is:
- freeipa dep8 test failures are currently being ignored
- freeipa itself needs work before it's usable again in disco
- freeipa dep8 test setup is failing because of the mentioned samba bug, which fails the installation of the test dependencies and as such the tests won't even run
- there is a real issue with samba that needs to be addressed. Discussion ongoing.
- in the meantime, samba migration is blocked
One can argue that the samba migration being blocked is correct. Its own dep8 tests pass, but they don't use winbind.
As to this change I'm proposing, Timo is ok with it:
<ahasenack> https:/
<ahasenack> that installs these packages: https:/
<ahasenack> we don't get freeipa-tests
<tjaalton> that's fine
<ahasenack> ok
<tjaalton> it's purpose is somewhat unclear to me anyway :)
<tjaalton> upstream doesn't use it either
<tjaalton> so might just as well drop it, maybe
<ahasenack> tjaalton: I'll proposed this: https:/
<tjaalton> upload away
But it will unblock samba, i.e., let it migrate into disco, with the known issue that is still being discussed.
Let's consider this MP from two points of view:
a) the consequences for the freeipa package itself (which is already ignoring dep8 failures, and is currently unusable in disco anyway)
b) the consequence of this change letting samba migrate into disco. Something will have to be done after to fix the bug.
I added a block-proposed tag to #1806035: "Not touching package as requested in bug 1806035 on Tue Dec 4 17:40:23 2018" so there is no risk of samba migrating even if this freeipa branch lands.