- All your considerations sound fine to me
- Neither the Debian nor the upstream changelog gave me other reasons to doubt this would be good
- Changes correctly retained/dropped
- yes to the egres test dropping
- patches added are upstream and seem safe
Strictly speaking the commit messages and changeelog could be slightly updated:
+ d/rules: don't build dnstap => add "... nor install dnstap.proto"
+ d/libdns1102.symbols: don't include dnstap symbols => is in d/libdns1104.symbols now
But that is up to you.
The autopkgtests look good, I think last cycle we also ran [1] against it.
I don't remember if that was helpful, if it was you might run that again before an upload.
All my feedback was ack/suggestion - so you already have my +1 on this - thanks for the Merge!
- All your considerations sound fine to me
- Neither the Debian nor the upstream changelog gave me other reasons to doubt this would be good
- Changes correctly retained/dropped
- yes to the egres test dropping
- patches added are upstream and seem safe
Strictly speaking the commit messages and changeelog could be slightly updated: symbols: don't include dnstap symbols => is in d/libdns1104. symbols now
+ d/rules: don't build dnstap => add "... nor install dnstap.proto"
+ d/libdns1102.
But that is up to you.
The autopkgtests look good, I think last cycle we also ran [1] against it.
I don't remember if that was helpful, if it was you might run that again before an upload.
All my feedback was ack/suggestion - so you already have my +1 on this - thanks for the Merge!
[1]: https:/ /git.launchpad. net/qa- regression- testing/ tree/scripts/ test-bind9. py