Merge ~ahasenack/ubuntu/+source/base-files:bionic-handle-was-removed-1895302 into ubuntu/+source/base-files:ubuntu/bionic-devel

[Andreas Hasenack]

Same as https://code.launchpad.net/~ahasenack/ubuntu/+source/base-files/+git/base-files/+merge/390766, but for bionic

Linked SRU bug has the template filled out, including a test case.

PPA: https://launchpad.net/~ahasenack/+archive/ubuntu/motd-news-wasremoved-handling/

[Bryce Harrington (bryce)]

See comments on the Xenial MP.

review: Approve

[Andreas Hasenack (ahasenack)]

After the discussion on the xenial mp, tagging and uploading b150e0508df3cca986407a01382a35366986a71b:

$ git push pkg upload/10.1ubuntu2.11
Enumerating objects: 26, done.
Counting objects: 100% (26/26), done.
Delta compression using up to 4 threads
Compressing objects: 100% (21/21), done.
Writing objects: 100% (21/21), 2.83 KiB | 964.00 KiB/s, done.
Total 21 (delta 15), reused 0 (delta 0)
To ssh://git.launchpad.net/~usd-import-team/ubuntu/+source/base-files
 * [new tag] upload/10.1ubuntu2.11 -> upload/10.1ubuntu2.11

$ dput ubuntu ../base-files_10.1ubuntu2.11_source.changes
Checking signature on .changes
gpg: ../base-files_10.1ubuntu2.11_source.changes: Valid signature from AC983EB5BF6BCBA9
Checking signature on .dsc
gpg: ../base-files_10.1ubuntu2.11.dsc: Valid signature from AC983EB5BF6BCBA9
Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading base-files_10.1ubuntu2.11.dsc: done.
  Uploading base-files_10.1ubuntu2.11.tar.xz: done.
  Uploading base-files_10.1ubuntu2.11_source.buildinfo: done.
  Uploading base-files_10.1ubuntu2.11_source.changes: done.
Successfully uploaded packages.

Unmerged commits

b150e05... by Andreas Hasenack on 2020-09-16

changelog

c52d1d8... by Andreas Hasenack on 2020-09-11

    - d/motd-news-config.postinst: always remove /e/d/motd-news.wasremoved
      if present

5d4519c... by Andreas Hasenack on 2020-09-16

    - d/postinst.in: only consider creating the .wasremoved file in upgrades,
      never fresh installs like in debootstrap for example

4849a64... by Andreas Hasenack on 2020-09-16

    - d/postinst.in: re-arrange the cascading conditionals around the
      creation of the .wasremoved file for better clarity

dcfb8b4... by Andreas Hasenack on 2020-09-11

  * Fix handling of /e/d/motd-news.wasremoved (LP: #1895302):
    - d/postinst.in: check if ubuntu-server is installed before creating
      the .wasremoved file

diff --git a/debian/changelog b/debian/changelog
index 3087eb8..c3e61e5 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,17 @@
+base-files (10.1ubuntu2.11) bionic; urgency=medium
+
+  * Fix handling of /e/d/motd-news.wasremoved (LP: #1895302):
+    - d/postinst.in: check if ubuntu-server is installed before creating
+      the .wasremoved file
+    - d/postinst.in: re-arrange the cascading conditionals around the
+      creation of the .wasremoved file for better clarity
+    - d/postinst.in: only consider creating the .wasremoved file in upgrades,
+      never fresh installs like in debootstrap for example
+    - d/motd-news-config.postinst: always remove /e/d/motd-news.wasremoved
+      if present
+
+ -- Andreas Hasenack <[e-mail]>  Wed, 16 Sep 2020 10:58:22 -0300
+
 base-files (10.1ubuntu2.10) bionic; urgency=medium
 
   [ Andreas Hasenack ]
diff --git a/debian/motd-news-config.postinst b/debian/motd-news-config.postinst
index a73427f..0be04fd 100644
--- a/debian/motd-news-config.postinst
+++ b/debian/motd-news-config.postinst
@@ -33,9 +33,9 @@ case "$1" in
           fi
           if [ -e /etc/default/motd-news.wasremoved ] && [ -e /etc/default/motd-news ]; then
               sed -i -e 's/^ENABLED=1/# Changed by motd-news-config.postinst:\n# config file was manually removed - disable the service\nENABLED=0/' /etc/default/motd-news
-              rm /etc/default/motd-news.wasremoved
           fi
       fi
+      rm -f /etc/default/motd-news.wasremoved
     ;;
 
     abort-upgrade|abort-remove|abort-deconfigure)
diff --git a/debian/postinst.in b/debian/postinst.in
index c347a62..055c914 100644
--- a/debian/postinst.in
+++ b/debian/postinst.in
@@ -130,12 +130,16 @@ fi
 # it does not put back the file with default contents which would
 # re-enable motd-news
 motd_news_config="/etc/default/motd-news"
-if [ ! -e ${motd_news_config} ]; then
-  if [ ! -e ${motd_news_config}.dpkg-remove ]; then
-    if [ ! -e ${motd_news_config}.dpkg-backup ]; then
-      touch ${motd_news_config}.wasremoved
-    fi
-  fi
+# only in upgrades, never fresh installs like in debootstrap
+if [ "$2" != "" ] && \
+   [ ! -e ${motd_news_config} ] && \
+   [ ! -e ${motd_news_config}.dpkg-remove ] && \
+   [ ! -e ${motd_news_config}.dpkg-backup ]; then
+      # The .wasremoved file only matters if ubuntu-server is installed,
+      # because that's what will pull in motd-news-config
+      if dpkg -l ubuntu-server 2>/dev/null | grep -q ^i; then
+        touch ${motd_news_config}.wasremoved
+      fi
 fi
 
 #DEBHELPER#