Merge ~ahasenack/ubuntu/+source/base-files:groovy-base-files-motd-optional-prio into ubuntu/+source/base-files:ubuntu/devel

Proposed by Andreas Hasenack on 2020-08-14
Status: Merged
Approved by: Andreas Hasenack on 2020-08-14
Approved revision: 0d25b10940459eec5b1d2ab407536ef7e936a641
Merged at revision: 0d25b10940459eec5b1d2ab407536ef7e936a641
Proposed branch: ~ahasenack/ubuntu/+source/base-files:groovy-base-files-motd-optional-prio
Merge into: ubuntu/+source/base-files:ubuntu/devel
Diff against target: 27 lines (+8/-0)
2 files modified
debian/changelog (+7/-0)
debian/control (+1/-0)
Reviewer Review Type Date Requested Status
Bryce Harrington 2020-08-14 Approve on 2020-08-14
Canonical Server Team 2020-08-14 Pending
Review via email: mp+389356@code.launchpad.net

Description of the change

Without a specific "Priority:" setting in d/control for motd-news-config, it inherits the one from base-files, which is "required". See the package currently uploaded to groovy at https://launchpad.net/ubuntu/groovy/amd64/motd-news-config/11ubuntu11

That has some implications, but the most notable is for the release upgrader. With that setting, do-release-upgrade from a focal desktop to groovy currently installs motd-news-config, even though there is no depepdency asking for it:

2020-08-14 14:13:21,809 DEBUG Installing 'motd-news-config' (priority in required set 'required' but not scheduled for install)

This MP sets it to "optional", which is what the majority of packages should have. See https://www.debian.org/doc/debian-policy/ch-archive.html#s-priorities

To post a comment you must log in.
Bryce Harrington (bryce) wrote :

Looks good, +1, was good opportunity to refamiliarize myself with the priority definitions in debian-policy.

review: Approve
Andreas Hasenack (ahasenack) wrote :

Thanks, tagging and uploading 0d25b10940459eec5b1d2ab407536ef7e936a641

$ git push pkg upload/11ubuntu12
Enumerating objects: 13, done.
Counting objects: 100% (13/13), done.
Delta compression using up to 4 threads
Compressing objects: 100% (9/9), done.
Writing objects: 100% (9/9), 1.10 KiB | 1.10 MiB/s, done.
Total 9 (delta 6), reused 0 (delta 0)
remote: Checking connectivity: 9, done.
To ssh://git.launchpad.net/~usd-import-team/ubuntu/+source/base-files
 * [new tag] upload/11ubuntu12 -> upload/11ubuntu12

$ dput ubuntu ../base-files_11ubuntu12_source.changes
Checking signature on .changes
gpg: ../base-files_11ubuntu12_source.changes: Valid signature from AC983EB5BF6BCBA9
Checking signature on .dsc
gpg: ../base-files_11ubuntu12.dsc: Valid signature from AC983EB5BF6BCBA9
Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading base-files_11ubuntu12.dsc: done.
  Uploading base-files_11ubuntu12.tar.xz: done.
  Uploading base-files_11ubuntu12_source.buildinfo: done.
  Uploading base-files_11ubuntu12_source.changes: done.
Successfully uploaded packages.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 6d9813e..eb44a50 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,10 @@
6+base-files (11ubuntu12) groovy; urgency=medium
7+
8+ * d/control: set priority to optional for motd-news-config to avoid
9+ having it pulled in by the release upgrader
10+
11+ -- Andreas Hasenack <andreas@canonical.com> Fri, 14 Aug 2020 14:28:12 -0300
12+
13 base-files (11ubuntu11) groovy; urgency=medium
14
15 * Move the /etc/default/motd-news conffile to the motd-news-config
16diff --git a/debian/control b/debian/control
17index d6b9138..1dbf9b9 100644
18--- a/debian/control
19+++ b/debian/control
20@@ -32,6 +32,7 @@ Description: LSB release information
21
22 Package: motd-news-config
23 Architecture: all
24+Priority: optional
25 Breaks: base-files (<< 11ubuntu11)
26 Replaces: base-files (<< 11ubuntu11)
27 Depends: ${shlibs:Depends}, ${misc:Depends}

Subscribers

People subscribed via source and target branches