Code review comment for ~ahasenack/ubuntu/+source/base-files:groovy-motd-news-config-split

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

> * debian/copyright
>
> This appears to still have template content needing filled out.
> I don't think the copyright file needs much detail; this is a pretty minimal package.

Sorry, I don't see the template bits.

> * debian/motd-news-config.motd-news.default
>
> The grammar of the comments in this file is rather poor. Given that
> we're making a new package, this seems like a good opportunity to
> improve the user documentation text.

Even though it's a new package, I'm wary of changing the contents of the config file as I would like to keep the md5 hash the same as it was.

> It appears if you delete (or don't have) 50-motd-news, it'll prompt you to
> create it but default to omitting it, which seems to be appropriate behavior:

Did you mean to test /etc/default/motd-news instead?

« Back to merge proposal