Merge ~ahasenack/ubuntu/+source/base-files:groovy-motd-news-config-split into ubuntu/+source/base-files:ubuntu/devel
Status: | Rejected | ||||
---|---|---|---|---|---|
Rejected by: | Andreas Hasenack | ||||
Proposed branch: | ~ahasenack/ubuntu/+source/base-files:groovy-motd-news-config-split | ||||
Merge into: | ubuntu/+source/base-files:ubuntu/devel | ||||
Diff against target: |
117 lines (+81/-1) 4 files modified
debian/base-files.maintscript (+1/-0) debian/changelog (+16/-0) debian/control (+13/-1) debian/motd-news-config.postinst (+51/-0) |
||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Bryce Harrington (community) | Approve | ||
Canonical Server Core Reviewers | Pending | ||
Review via email: mp+388400@code.launchpad.net |
Description of the change
PPA via bileto: https:/
This bileto run is a bit buggy, probably because of the NEw package. I'm pinging sil2100, but he is busy today with a cloud-init/grub fire.
One of 3 packages needed to fix bug https:/
The overall plan is to have motd-news only enabled on server systems after this upgrade. What it does:
- the /etc/default/
- ubuntu-server has a dependency on motd-news-config
- new base-files breaks old ubuntu-server, forcing an upgrade if it is installed
The versions used in these breaks/replaces have to be very precise for this to work, so between now and whenever these are uploaded, I'll check again.
For now in groovy we have:
base-files 11ubuntu10
ubuntu-meta 1.452
Therefore:
ubuntu-server 1.453:
Depends: motd-news-config
base-files 11ubuntu11:
Breaks/Replaces: ubuntu-server (<< 1.453)
rm_conffile /etc/default/
motd-news-config 1 (NEW):
Breaks/Replaces: base-files (<< 11ubuntu11)
To review motd-news-config, grab the source from the ppa. It's also in a branch, but a bit messy with lots of ppaN and changelog commits.
There is one lintian error in motd-news-config, and that's about the usage of ENABLED in an /etc/default/* file. This package does not even have an initscript or systemd service: that exists in base-files. And even there it's a timer that runs the one-shot service script. I thought about adding an override, but thought it best to keep the lintian error visible for the moment. Considering this package will be SRUed all the way back to xenial systems, I don't think it warrants extensive changes to get rid of ENABLED=1/0 in that file. But the AA will have the final sya.
For the PPA, I commited directly to src:ubuntu-meta instead of running its ./update script, as I couldn't convince that script to use a branch of mine instead of the official ubuntu seeds repository. I'll propose that branch as well, but I can't land it until motd-news-config is accepted from the NEW queue (I haven't uploaded it yet).
Here are the tests I've been running:
a) base-files installed, ubuntu-server installed, unmodified /e/d/motd-news
apt install base-files
- upgrades ubuntu-server
- installs motd-news-config
- /e/d/motd-news remains, motd-news remains enabled
b) base-files installed, ubuntu-server installed, modified /e/d/motd-news
apt install base-files
- upgrades ubuntu-server
- installs motd-news-config
- /e/d/motd-news remains with the original modification
c) base-files installed, ubuntu-server not installed, unmodified /e/d/motd-news
apt install base-files
- upgrades base-files
- removes /e/d/motd-news
- motd-news is disabled
d) base-files installed, ubuntu-server not installed, modified /e/d/motd-news
apt install base-files
- upgrades base-files
- /e/d/motd-news gets renamed to backup
- motd-news is disabled
e) removing motd-news-config will also remove ubuntu-server (since it's a depends, and not a recommends)
ubuntu-meta seed change: https:/ /code.launchpad .net/~ahasenack /ubuntu- seeds/+ git/ubuntu- seeds/+ merge/388403