Merge ~ahasenack/ubuntu/+source/base-files:groovy-remove-uptime into ubuntu/+source/base-files:ubuntu/devel

Proposed by Andreas Hasenack
Status: Merged
Merged at revision: 0f66926d99392707e0278a028e5d3f8448cfb277
Proposed branch: ~ahasenack/ubuntu/+source/base-files:groovy-remove-uptime
Merge into: ubuntu/+source/base-files:ubuntu/devel
Diff against target: 33 lines (+8/-5)
2 files modified
debian/changelog (+7/-0)
motd/50-motd-news (+1/-5)
Reviewer Review Type Date Requested Status
Bryce Harrington (community) Approve
Canonical Server Core Reviewers Pending
Review via email: mp+386923@code.launchpad.net

Description of the change

Stop including the uptime in the user-agent string. I opted to zero the value instead of removing the field entirely to avoid breaking possible parsers out there.

To post a comment you must log in.
Revision history for this message
Andreas Hasenack (ahasenack) wrote :

I just pushed another commit not including uptime at all. We should be the only consumers, and if it breaks something, we will know.

Revision history for this message
Bryce Harrington (bryce) wrote :

If we're the only consumers then yep, looks good to drop entirely.

review: Approve
Revision history for this message
Andreas Hasenack (ahasenack) wrote :

Thanks, tagging and uploading 0f66926d99392707e0278a028e5d3f8448cfb277

$ git push pkg upload/11ubuntu8
Enumerating objects: 18, done.
Counting objects: 100% (18/18), done.
Delta compression using up to 4 threads
Compressing objects: 100% (13/13), done.
Writing objects: 100% (13/13), 1.46 KiB | 135.00 KiB/s, done.
Total 13 (delta 9), reused 0 (delta 0)
To ssh://git.launchpad.net/~usd-import-team/ubuntu/+source/base-files
 * [new tag] upload/11ubuntu8 -> upload/11ubuntu8

$ dput ubuntu ../base-files_11ubuntu8_source.changes
Checking signature on .changes
gpg: ../base-files_11ubuntu8_source.changes: Valid signature from AC983EB5BF6BCBA9
Checking signature on .dsc
gpg: ../base-files_11ubuntu8.dsc: Valid signature from AC983EB5BF6BCBA9
Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading base-files_11ubuntu8.dsc: done.
  Uploading base-files_11ubuntu8.tar.xz: done.
  Uploading base-files_11ubuntu8_source.buildinfo: done.
  Uploading base-files_11ubuntu8_source.changes: done.
Successfully uploaded packages.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 262b63a..c92e176 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,10 @@
6+base-files (11ubuntu8) groovy; urgency=medium
7+
8+ * motd/50-motd-news: don't include uptime in the user-agent string
9+ (LP: #1886572)
10+
11+ -- Andreas Hasenack <andreas@canonical.com> Mon, 06 Jul 2020 19:50:22 -0300
12+
13 base-files (11ubuntu7) groovy; urgency=medium
14
15 [ Simon Deziel ]
16diff --git a/motd/50-motd-news b/motd/50-motd-news
17index b697c78..a0d5424 100644
18--- a/motd/50-motd-news
19+++ b/motd/50-motd-news
20@@ -100,12 +100,8 @@ if [ -x /usr/bin/cloud-id ]; then
21 fi
22 fi
23
24-# Some messages may only be pertinent before or after some amount of uptime
25-read up idle < /proc/uptime
26-uptime="uptime/$up/$idle"
27-
28 # Piece together the user agent
29-USER_AGENT="curl/$curl_ver $lsb $platform $cpu $uptime cloud_id/$cloud_id"
30+USER_AGENT="curl/$curl_ver $lsb $platform $cpu cloud_id/$cloud_id"
31
32 # Loop over any configured URLs
33 for u in $URLS; do

Subscribers

People subscribed via source and target branches