Merge ~ahasenack/ubuntu/+source/backuppc:eoan-backuppc-merge into ubuntu/+source/backuppc:debian/sid
Status: | Rejected |
---|---|
Rejected by: | Andreas Hasenack |
Proposed branch: | ~ahasenack/ubuntu/+source/backuppc:eoan-backuppc-merge |
Merge into: | ubuntu/+source/backuppc:debian/sid |
Diff against target: |
530 lines (+380/-2) 3 files modified
debian/changelog (+377/-0) debian/control (+2/-1) debian/init (+1/-1) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Canonical Server Core Reviewers | Pending | ||
Canonical Server | Pending | ||
Review via email: mp+368485@code.launchpad.net |
Description of the change
PPA with a test build: ppa:ahasenack/
https:/
DEP8 tests passed locally.
This merge from debian almost became a sync. It still can, but maybe not.
The remaining delta, part of the change to fix http://
Without the delta:
$ l /etc/rc?
lrwxrwxrwx 1 root root 18 Jun 6 18:26 /etc/rc0.
lrwxrwxrwx 1 root root 18 Jun 6 18:26 /etc/rc1.
lrwxrwxrwx 1 root root 18 Jun 6 18:26 /etc/rc2.
lrwxrwxrwx 1 root root 18 Jun 6 18:26 /etc/rc3.
lrwxrwxrwx 1 root root 18 Jun 6 18:26 /etc/rc4.
lrwxrwxrwx 1 root root 18 Jun 6 18:26 /etc/rc5.
lrwxrwxrwx 1 root root 18 Jun 6 18:26 /etc/rc6.
With the delta:
$ l /etc/rc?
lrwxrwxrwx 1 root root 18 Jun 6 18:28 /etc/rc1.
lrwxrwxrwx 1 root root 18 Jun 6 18:28 /etc/rc2.
lrwxrwxrwx 1 root root 18 Jun 6 18:28 /etc/rc3.
lrwxrwxrwx 1 root root 18 Jun 6 18:28 /etc/rc4.
lrwxrwxrwx 1 root root 18 Jun 6 18:28 /etc/rc5.
We see that the rc6.d and rc0.d stop links are gone, as intended. How important is that nowadays? I'm not sure. The spec that was referenced in the debian bug is https:/
I could perhaps send an email to ubuntu-devel@ perhaps asking about this.
These are ancient, pre-upstart even. Are these init scripts even used now, with systemd? If not, then I think you are safe to just drop them. I think a big part of the reason to move to upstart/systemd was to better handle start/stop with more of an event driven architecture.
Even if they are still used in some fashion, my guess is they're not impacting the shutdown time. And, if they do, then I'd wonder if they were doing something important that shouldn't be ignored.
+1 to sync :-)