Merge ~ahasenack/ubuntu/+source/backuppc:trusty-backuppc-smb-1576187 into ubuntu/+source/backuppc:ubuntu/trusty-devel
Status: | Merged | ||||||||
---|---|---|---|---|---|---|---|---|---|
Approved by: | Christian Ehrhardt | ||||||||
Approved revision: | 7d660d980d5a1ec9ba52e77025060c039cc673f2 | ||||||||
Merged at revision: | 79e410c3d44c5783a8e5552e7614c81bb5120800 | ||||||||
Proposed branch: | ~ahasenack/ubuntu/+source/backuppc:trusty-backuppc-smb-1576187 | ||||||||
Merge into: | ubuntu/+source/backuppc:ubuntu/trusty-devel | ||||||||
Diff against target: |
204 lines (+167/-0) 5 files modified
debian/changelog (+8/-0) debian/patches/smb-compat-fix.patch (+66/-0) debian/rules (+1/-0) debian/tests/control (+3/-0) debian/tests/smb-backup (+89/-0) |
||||||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Christian Ehrhardt (community) | Approve | ||
Canonical Server | Pending | ||
Canonical Server Core Reviewers | Pending | ||
Review via email: mp+356883@code.launchpad.net |
Description of the change
Same as https:/
This branch applies the fix that upstream chose for #1576187. This is different from what was applied in debian (which is what we have in bionic and later), but also fixes the problem, and in a better way we believe.
While writing up the testing instructions, I realized these could be easily scripted, and as such I'm also adding a simple samba-based DEP8 test to this package. This test actually exercises the present bug, so if it's run with the package without the fix, it will correctly fail.
The same dep8 test can and will be added to cosmic+1 once it opens (see https:/
Testing instructions are provided in the bug, but they are the same as the newly added DEP8 test, which you can run manually if you want.
Bileto ticket: https:/
PPA: sudo add-apt-repository ppa:ci-
I don't understand why the trusty dep8 tests are not running in bileto. They ran locally via autopkgtest in a VM just fine. Is it a bileto restriction or shortcoming?