Code review comment for ~ahasenack/ubuntu/+source/apache2:cosmic-apache2-2.4.33-3

Christian Ehrhardt  (paelzer) wrote :

For Brotli I found that it is a new compression algorithm better than gzip.
It is not needed right now, but usually google funded internet standards often become "required" over time to stay current. So while I ack to disabling it right now I'd ask you to file a MIR for it to be able to enable it at some point unless the security review unveils massive issues with it.

Thanks for the tests, it didn't find an issue with your merge but with the tests - never the less that is good later on when maintaining this.

The merge is good now asid one nit pick - IMHO it misses one space in the changelog.
This is no deal breaker, so I'll leave it up to you if you want to fix it or not (see inline comment below).
Everything else is good now, so +1

review: Approve

« Back to merge proposal