Merge ~ahasenack/ubuntu-seeds:focal-realmd-adcli into ~ubuntu-core-dev/ubuntu-seeds/+git/platform:focal

Proposed by Andreas Hasenack
Status: Merged
Approved by: Andreas Hasenack
Approved revision: 7b82818b00881ea4a54c6c731661408728eff106
Merged at revision: 7b82818b00881ea4a54c6c731661408728eff106
Proposed branch: ~ahasenack/ubuntu-seeds:focal-realmd-adcli
Merge into: ~ubuntu-core-dev/ubuntu-seeds/+git/platform:focal
Diff against target: 12 lines (+2/-0)
1 file modified
supported-misc-servers (+2/-0)
Reviewer Review Type Date Requested Status
Seth Arnold (community) Approve
Bryce Harrington Approve
Canonical Server Core Reviewers Pending
Review via email: mp+388428@code.launchpad.net

Description of the change

Since the version of realmd and adcli in focal is the same as in groovy, and the groovy MIRs were approved, let's push these two packages into main for focal as well.

I won't land this before I get an AA's approval.

To post a comment you must log in.
Revision history for this message
Bryce Harrington (bryce) wrote :

Is the inclusion of this into focal based on requirements and/or user needs? I ask because in reviewing the MIR there were some doubts raised about maintainability due to the low upstream release activity, which might be pertinent for LTS support on that release. However, if this is driven by e.g. customer need or canonical strategy that may be sufficient justification.

I don't think I've ever been involved with a MIR to an LTS release before, so am unsure on policy there. I read the MIR guidelines again, and reviewed both linked bug reports to see if they addressed this, but neither elucidated me.

review: Needs Information
Revision history for this message
Andreas Hasenack (ahasenack) wrote :

Right, this is unusual, but it all started with a support case for focal. We got the MIRs landed for groovy, and since the realmd and adcli versions are identical, a query was made to an AA to see if it would be acceptable to make the change for focal as well, and he said it should be fine.

I planned to ask an AA on #irc this morning, but I think I'll also add a review slot. And will also ask security.

Revision history for this message
Bryce Harrington (bryce) wrote :

Ok, sounds like a good plan. The change itself LGTM so will approve.

It would probably help other reviewers to summarize what the support case was, as I suspect that will influence decision-making.

review: Approve
Revision history for this message
Seth Arnold (seth-arnold) wrote :

This makes sense to me: I don't see something happening in the next two releases to make us seriously question putting these into an LTS.

Thanks

review: Approve
Revision history for this message
Andreas Hasenack (ahasenack) wrote :

Got a +1 from vorlon on irc:

<vorlon> ahasenack: it's only a supported seed so no point release impact. +1 for the change, go for it and I can promote

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/supported-misc-servers b/supported-misc-servers
2index 96fd81c..72aad79 100644
3--- a/supported-misc-servers
4+++ b/supported-misc-servers
5@@ -61,6 +61,8 @@ Authentication:
6
7 * sssd
8 * sssd-tools
9+ * adcli
10+ * realmd
11
12 Backup:
13

Subscribers

People subscribed via source and target branches