Merge lp:~ahasenack/landscape-client/drop-gnupginterface into lp:~landscape/landscape-client/trunk

Proposed by Andreas Hasenack
Status: Merged
Approved by: Chris Glass
Approved revision: 591
Merged at revision: 590
Proposed branch: lp:~ahasenack/landscape-client/drop-gnupginterface
Merge into: lp:~landscape/landscape-client/trunk
Diff against target: 47 lines (+7/-1)
2 files modified
debian/control (+0/-1)
debian/rules (+7/-0)
To merge this branch: bzr merge lp:~ahasenack/landscape-client/drop-gnupginterface
Reviewer Review Type Date Requested Status
Chris Glass (community) Approve
Alberto Donato (community) Approve
Review via email: mp+135233@code.launchpad.net

Description of the change

Bug #1045237 asked us to remove the dependency on python-gnupginterface for quantal and up. Later, they committed to the ubuntu landscape-client package a change that drops it for raring. This branch conditionally drops this dependency for releases >= quantal.

To post a comment you must log in.
591. By Andreas Hasenack

Drop gnupginterface for quantal too.

Revision history for this message
Alberto Donato (ack) wrote :

Looks good, +1!

review: Approve
Revision history for this message
Chris Glass (tribaal) wrote :

Looks good! +1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/control'
2--- debian/control 2012-09-26 14:18:10 +0000
3+++ debian/control 2012-11-20 20:17:22 +0000
4@@ -11,7 +11,6 @@
5 Architecture: any
6 Depends: ${python:Depends}, ${misc:Depends}, ${extra:Depends},
7 ${shlibs:Depends},
8- python-gnupginterface,
9 python-twisted-core,
10 python-apt,
11 ca-certificates,
12
13=== modified file 'debian/rules'
14--- debian/rules 2012-09-26 14:04:47 +0000
15+++ debian/rules 2012-11-20 20:17:22 +0000
16@@ -88,6 +88,7 @@
17 dh_fixperms
18 dh_shlibdeps
19
20+# hardy only
21 ifneq (,$(findstring $(dist_release),hardy))
22 # We depend on bug-fixed versions of python-dbus and pycurl on hardy
23 echo "extra:Depends=python-dbus" >> $(landscape_common_substvars)
24@@ -95,17 +96,23 @@
25 # The python-image-store-proxy package is needed for the eucalyptus plugin
26 echo "extra:Suggests=python-image-store-proxy" >> $(landscape_common_substvars)
27 endif
28+# lucid only
29 ifneq (,$(filter $(dist_release),lucid))
30 # We want libpam-modules in lucid
31 echo "extra:Depends=libpam-modules (>= 1.0.1-9ubuntu3), python-dbus" >> $(landscape_common_substvars)
32 echo "extra:Depends=python-pycurl, hal" >> $(landscape_client_substvars)
33 endif
34+# not hardy, not lucid
35 ifeq (,$(filter $(dist_release),hardy lucid))
36 # Starting natty, no more hal or dbus
37 echo "extra:Depends=libpam-modules (>= 1.0.1-9ubuntu3)" >> $(landscape_common_substvars)
38 echo "extra:Depends=python-pycurl, gir1.2-gudev-1.0 (>= 165-0ubuntu2), python-gi" >> $(landscape_client_substvars)
39 echo "extra:Suggests=python-dbus, hal" >> $(landscape_client_substvars)
40 endif
41+# from quantal onwards, we don't want python-gnupginterface anymore (#1045237)
42+ifneq (,$(filter $(dist_release),hardy lucid oneiric precise))
43+ echo "extra:Depends=python-gnupginterface" >> $(landscape_common_substvars)
44+endif
45
46 ifeq ($(use_dhpython2),yes)
47 dh_python2 --no-guessing-versions

Subscribers

People subscribed via source and target branches

to all changes: