Merge lp:~ahasenack/charms/precise/nova-compute/use-charm-dir into lp:~openstack-charmers/charms/precise/nova-compute/ha-support

Proposed by Andreas Hasenack
Status: Merged
Merged at revision: 57
Proposed branch: lp:~ahasenack/charms/precise/nova-compute/use-charm-dir
Merge into: lp:~openstack-charmers/charms/precise/nova-compute/ha-support
Diff against target: 112 lines (+17/-15)
5 files modified
hooks/lib/nova/nova-common (+6/-5)
hooks/lib/openstack-common (+2/-2)
hooks/nova-compute-common (+4/-3)
hooks/nova-compute-relations (+4/-4)
revision (+1/-1)
To merge this branch: bzr merge lp:~ahasenack/charms/precise/nova-compute/use-charm-dir
Reviewer Review Type Date Requested Status
OpenStack Charmers Pending
Review via email: mp+161114@code.launchpad.net

Description of the change

This branch makes the nova-compute charm use CHARM_DIR instead of a hardcoded path for the charm location on disk, thereby being compatible with both juju and juju-core.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'hooks/lib/nova/nova-common'
2--- hooks/lib/nova/nova-common 2013-04-04 23:34:30 +0000
3+++ hooks/lib/nova/nova-common 2013-04-26 13:16:05 +0000
4@@ -3,19 +3,20 @@
5 # Common utility functions used across all nova charms.
6
7 CONFIG_CHANGED=False
8+HOOKS_DIR="$CHARM_DIR/hooks"
9
10 # Load the common OpenStack helper library.
11-if [[ -e $CHARM_DIR/lib/openstack-common ]] ; then
12- . $CHARM_DIR/lib/openstack-common
13+if [[ -e $HOOKS_DIR/lib/openstack-common ]] ; then
14+ . $HOOKS_DIR/lib/openstack-common
15 else
16- juju-log "Couldn't load $CHARM_DIR/lib/opentack-common." && exit 1
17+ juju-log "Couldn't load $HOOKS_DIR/lib/opentack-common." && exit 1
18 fi
19
20 set_or_update() {
21 # Update config flags in nova.conf or api-paste.ini.
22 # Config layout changed in Folsom, so this is now OpenStack release specific.
23 local rel=$(get_os_codename_package "nova-common")
24- . $CHARM_DIR/lib/nova/$rel
25+ . $HOOKS_DIR/lib/nova/$rel
26 nova_set_or_update $@
27 }
28
29@@ -130,7 +131,7 @@
30
31 # load the release helper library for pre/post upgrade hooks specific to the
32 # release we are upgrading to.
33- . $CHARM_DIR/lib/nova/$new_rel
34+ . $HOOKS_DIR/lib/nova/$new_rel
35
36 # new release specific pre-upgrade hook
37 nova_pre_upgrade "$orig_os_rel"
38
39=== modified file 'hooks/lib/openstack-common'
40--- hooks/lib/openstack-common 2013-04-04 23:34:30 +0000
41+++ hooks/lib/openstack-common 2013-04-26 13:16:05 +0000
42@@ -762,7 +762,7 @@
43 exit 1
44 fi
45 # our default unit_path
46- unit_path="/var/lib/juju/units/${JUJU_UNIT_NAME/\//-}/charm/scripts/scriptrc"
47+ unit_path="$CHARM_DIR/scripts/scriptrc"
48 echo $unit_path
49 tmp_rc="/tmp/${JUJU_UNIT_NAME/\//-}rc"
50
51@@ -771,7 +771,7 @@
52 do
53 if `echo $env_var | grep -q script_path`; then
54 # well then we need to reset the new unit-local script path
55- unit_path="/var/lib/juju/units/${JUJU_UNIT_NAME/\//-}/charm/${env_var/script_path=/}"
56+ unit_path="$CHARM_DIR/${env_var/script_path=/}"
57 else
58 echo "export $env_var" >> $tmp_rc
59 fi
60
61=== modified file 'hooks/nova-compute-common'
62--- hooks/nova-compute-common 2013-04-05 18:43:45 +0000
63+++ hooks/nova-compute-common 2013-04-26 13:16:05 +0000
64@@ -8,6 +8,7 @@
65 API_CONF="/etc/nova/api-paste.ini"
66 QUANTUM_CONF="/etc/quantum/quantum.conf"
67 LIBVIRTD_CONF="/etc/libvirt/libvirtd.conf"
68+HOOKS_DIR="$CHARM_DIR/hooks"
69
70 if [ -f /etc/nova/nm.conf ]; then
71 NET_MANAGER=$(cat /etc/nova/nm.conf)
72@@ -33,10 +34,10 @@
73 ;;
74 esac
75
76-if [[ -e $CHARM_DIR/lib/nova/nova-common ]] ; then
77- . $CHARM_DIR/lib/nova/nova-common
78+if [[ -e $HOOKS_DIR/lib/nova/nova-common ]] ; then
79+ . $HOOKS_DIR/lib/nova/nova-common
80 else
81- juju-log "$CHARM: Couldn't load $CHARM_DIR/lib/nova-common" && exit 1
82+ juju-log "$CHARM: Couldn't load $HOOKS_DIR/lib/nova-common" && exit 1
83 fi
84
85 determine_compute_package() {
86
87=== modified file 'hooks/nova-compute-relations'
88--- hooks/nova-compute-relations 2013-04-11 03:18:41 +0000
89+++ hooks/nova-compute-relations 2013-04-26 13:16:05 +0000
90@@ -1,11 +1,11 @@
91 #!/bin/bash -e
92-CHARM_DIR=$(dirname $0)
93+HOOKS_DIR="$CHARM_DIR/hooks"
94 ARG0=${0##*/}
95
96-if [[ -e $CHARM_DIR/nova-compute-common ]] ; then
97- . $CHARM_DIR/nova-compute-common
98+if [[ -e $HOOKS_DIR/nova-compute-common ]] ; then
99+ . $HOOKS_DIR/nova-compute-common
100 else
101- juju-log "ERROR: Could not load nova-compute-common from $CHARM_DIR"
102+ juju-log "ERROR: Could not load nova-compute-common from $HOOKS_DIR"
103 fi
104
105 function install_hook {
106
107=== modified file 'revision'
108--- revision 2013-04-11 03:18:41 +0000
109+++ revision 2013-04-26 13:16:05 +0000
110@@ -1,1 +1,1 @@
111-90
112+91

Subscribers

People subscribed via source and target branches