Code review comment for lp:~ahasenack/apport/samba-security-share-bugpattern

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

Thanks for the review.

I didn't want to use search-bugs with --consolidate before this was merged :)

Regarding why it didn't caught #1634119 itself, yes, it's because we need the option to be actually used in the config file, or else the reason smbd isn't restarting is something else. That user did some debugging on his own and uploaded the smb.conf file after he had fixed it.

Some of the bugs (most actually) I left as incomplete expecting the users to come back after they fixed the config, in which case we would close them as invalid or duplicate. That would have been a nice closure. But it's not happening, and the bugs keep coming in, that's why I decided it's time for a bug pattern :)

« Back to merge proposal