Merge lp:~agilebg/openobject-italia/imp_save_fiscalcode_data into lp:~nicolariolini/openobject-italia/save_fiscalcode_data

Proposed by Lorenzo Battistini
Status: Merged
Merged at revision: 233
Proposed branch: lp:~agilebg/openobject-italia/imp_save_fiscalcode_data
Merge into: lp:~nicolariolini/openobject-italia/save_fiscalcode_data
Diff against target: 129 lines (+41/-32)
2 files modified
l10n_it_fiscalcode/fiscalcode.py (+0/-4)
l10n_it_fiscalcode/wizard/compute_fc.py (+41/-28)
To merge this branch: bzr merge lp:~agilebg/openobject-italia/imp_save_fiscalcode_data
Reviewer Review Type Date Requested Status
Nicola Riolini - Micronaet Pending
Review via email: mp+194477@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Nicola Riolini - Micronaet (nicolariolini) wrote :

Direi che ha migliorato aspetto :)
Ok per me

Revision history for this message
Lorenzo Battistini (elbati) wrote :

On 11/08/2013 11:14 AM, Nicola Riolini - Micronaet wrote:
> Direi che ha migliorato aspetto :)
> Ok per me

Puoi mergiarlo nel tuo branch con

bzr merge lp:~agilebg/openobject-italia/imp_save_fiscalcode_data

Revision history for this message
Nicola Riolini - Micronaet (nicolariolini) wrote :

grazie, ho visto il suggerimento di Launchapad, spero di non avere fatto casini :)

Revision history for this message
Lorenzo Battistini (elbati) wrote :

On 11/08/2013 11:21 AM, Nicola Riolini - Micronaet wrote:
> grazie, ho visto il suggerimento di Launchapad, spero di non avere fatto casini :)

Non ne hai fatti :-)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'l10n_it_fiscalcode/fiscalcode.py'
2--- l10n_it_fiscalcode/fiscalcode.py 2013-11-08 09:43:06 +0000
3+++ l10n_it_fiscalcode/fiscalcode.py 2013-11-08 10:03:22 +0000
4@@ -20,10 +20,6 @@
5 ##############################################################################
6
7 from osv import fields, osv
8-import tools
9-import pooler
10-from tools.translate import _
11-import datetime
12
13
14 class res_partner(osv.osv):
15
16=== modified file 'l10n_it_fiscalcode/wizard/compute_fc.py'
17--- l10n_it_fiscalcode/wizard/compute_fc.py 2013-11-08 09:43:06 +0000
18+++ l10n_it_fiscalcode/wizard/compute_fc.py 2013-11-08 10:03:22 +0000
19@@ -20,8 +20,6 @@
20 ##############################################################################
21
22 from osv import fields, osv
23-import tools
24-import pooler
25 from tools.translate import _
26 import datetime
27
28@@ -44,17 +42,26 @@
29
30 _defaults = {
31 # Leggo da res.partner i dati se presenti per impostarli come default:
32- 'fiscalcode_surname': lambda s, cr, uid, c: s.get_default_from_partner(
33- cr, uid, 'fiscalcode_surname', context=c),
34- 'fiscalcode_firstname': lambda s, cr, uid, c:
35- s.get_default_from_partner(cr, uid,
36- 'fiscalcode_firstname', context=c),
37- 'birth_date': lambda s, cr, uid, c: s.get_default_from_partner(cr, uid,
38- 'birth_date', context=c),
39- 'birth_city': lambda s, cr, uid, c: s.get_default_from_partner(cr, uid,
40- 'birth_city', context=c),
41- 'sex': lambda s, cr, uid, c: s.get_default_from_partner(cr, uid, 'sex',
42- context=c),
43+ 'fiscalcode_surname': (
44+ lambda s, cr, uid, c: s.get_default_from_partner(
45+ cr, uid, 'fiscalcode_surname', context=c)
46+ ),
47+ 'fiscalcode_firstname': (
48+ lambda s, cr, uid, c: s.get_default_from_partner(
49+ cr, uid, 'fiscalcode_firstname', context=c)
50+ ),
51+ 'birth_date': (
52+ lambda s, cr, uid, c: s.get_default_from_partner(
53+ cr, uid, 'birth_date', context=c)
54+ ),
55+ 'birth_city': (
56+ lambda s, cr, uid, c: s.get_default_from_partner(
57+ cr, uid, 'birth_city', context=c)
58+ ),
59+ 'sex': (
60+ lambda s, cr, uid, c: s.get_default_from_partner(
61+ cr, uid, 'sex', context=c)
62+ ),
63 }
64
65 def get_default_from_partner(self, cr, uid, field, context=None):
66@@ -69,7 +76,7 @@
67 if not partner_id:
68 return False
69 partner_proxy = self.pool.get('res.partner').browse(
70- cr, uid, partner_id, context=context)
71+ cr, uid, partner_id, context=context)
72 res = partner_proxy.__getattr__(field)
73
74 if field == 'birth_city': # many2one
75@@ -158,10 +165,12 @@
76 context)
77 form_obj = self.browse(cr, uid, ids, context)
78 for fields in form_obj:
79- if (not fields.fiscalcode_surname or
80+ if (
81+ not fields.fiscalcode_surname or
82 not fields.fiscalcode_firstname or
83 not fields.birth_date or
84- not fields.birth_city or not fields.sex):
85+ not fields.birth_city or not fields.sex
86+ ):
87 raise osv.except_osv(_('Error'),
88 _('One or more fields are missing'))
89 if not fields.birth_city.cadaster_code:
90@@ -169,9 +178,10 @@
91 _('Cataster code is missing'))
92 birth_date = datetime.datetime.strptime(fields.birth_date,
93 "%Y-%m-%d")
94- CF = self._codicefiscale(fields.fiscalcode_surname,
95- fields.fiscalcode_firstname,
96- str(birth_date.day),
97+ CF = self._codicefiscale(
98+ fields.fiscalcode_surname,
99+ fields.fiscalcode_firstname,
100+ str(birth_date.day),
101 str(birth_date.month), str(birth_date.year), fields.sex,
102 fields.birth_city.cadaster_code)
103 if partner.fiscalcode and partner.fiscalcode != CF:
104@@ -181,13 +191,16 @@
105 one (%s). If you want to use the computed one, remove
106 the existing one') % (partner.fiscalcode, CF"""))
107 self.pool.get('res.partner').write(
108- cr, uid, active_id,
109- {'fiscalcode': CF,
110- 'individual': True,
111- # Storicizzo in res.partner i dati usati dal wizard
112- 'fiscalcode_surname': fields.fiscalcode_surname,
113- 'fiscalcode_firstname': fields.fiscalcode_firstname,
114- 'birth_date': fields.birth_date,
115- 'birth_city': fields.birth_city.id if fields.birth_city else False,
116- 'sex': fields.sex, })
117+ cr, uid, active_id,
118+ {'fiscalcode': CF,
119+ 'individual': True,
120+ # Storicizzo in res.partner i dati usati dal wizard
121+ 'fiscalcode_surname': fields.fiscalcode_surname,
122+ 'fiscalcode_firstname': fields.fiscalcode_firstname,
123+ 'birth_date': fields.birth_date,
124+ 'birth_city': (
125+ fields.birth_city.id if fields.birth_city
126+ else False
127+ ),
128+ 'sex': fields.sex, })
129 return {}

Subscribers

People subscribed via source and target branches