Merge lp:~agilebg/openobject-italia/7.0-bug-1221567-elbati into lp:~openobject-italia-core-devs/openobject-italia/italian-addons-7.0

[Lorenzo Battistini]

[Leonardo Pistone (lepistone)]

Thanks Lorenzo.

Would that be a tad more readable if you switched the if / else block removing "not"?

review: Needs Fixing

[lp:~agilebg/openobject-italia/7.0-bug-1221567-elbati]

225. By Lorenzo Battistini on 2013-11-06

[IMP] switched the if / else block removing "not"

[Lorenzo Battistini (elbati)]

On 10/28/2013 12:05 PM, Leonardo Pistone - Agile BG wrote:
> Review: Needs Fixing
>
> Thanks Lorenzo.
>
> Would that be a tad more readable if you switched the if / else block removing "not"?

Done!

[Leonardo Pistone (lepistone)]

Thanks Lorenzo, LGTM

review: Approve (code review, no test)

=== modified file 'l10n_it_vat_registries/invoice.py'
--- l10n_it_vat_registries/invoice.py	2013-08-21 16:15:06 +0000
+++ l10n_it_vat_registries/invoice.py	2013-11-06 15:08:31 +0000
@@ -68,12 +68,18 @@
 
     def _get_invoice_total(self, move):
         total = 0.0
+        receivable_payable_found = False
         for move_line in move.line_id:
             if move_line.account_id.type == 'receivable':
                 total += move_line.debit or ( - move_line.credit)
+                receivable_payable_found = True
             elif move_line.account_id.type == 'payable':
                 total += ( - move_line.debit) or move_line.credit
-        return abs(total)
+                receivable_payable_found = True
+        if receivable_payable_found:
+            return abs(total)
+        else:
+            return abs(move.amount)
     
     def build_parent_tax_codes(self, tax_code):
         res={}