Code review comment for lp:~agilebg/openobject-addons/6.1-bug-1083635-elbati

Revision history for this message
Olivier Dony (Odoo) (odo-openerp) wrote :

Thanks for the fast submission!

Would it be possible to ask Leonardo to review it, as it seems you merged the recent 6.1 22% patch on top of your previous patch, but the renaming of 22a -> 2a has been dropped, so this patch has twice the same XML IDs defined (22a, 22b). Probably not what you want.

Maybe it would be possible to re-do the patch manually based on the latest CSV in 6.1. If I understand correctly the result should only contain lines that change the `base_sign` and `tax_sign` columns to -1 for "detraibile" and "indetraibile" tax definitions. Is that right?

Thanks!

review: Needs Information

« Back to merge proposal