Merge lp:~agilebg/openerp-product-attributes/adding_product_category_code_7 into lp:~product-core-editors/openerp-product-attributes/7.0

[Lorenzo Battistini]

[Serpent Consulting Services (serpent-consulting-services)]

Just quick things I noticed:
- 'auto_install'should be used instead of 'active' in v7.
- Are we creating a module for one field? May be its better to add this into parent module (lp:openerp-product-attributes) if product model is used there.

Just an opinion,
Thanks.

[Lorenzo Battistini (elbati)]

On 07/24/2013 09:53 PM, Serpent Consulting Services wrote:
> - Are we creating a module for one field? May be its better to add this into parent module (lp:openerp-product-attributes) if product model is used there.

Do you mean 'product_custom_attributes' module?
In general, I think every module should be as much atomic as possible,
for several reasons: admin may want only that functionality, we can
easily maintain only that functionality, without caring about others not
directly related...

[Pedro Manuel Baeza (pedro.baeza)]

I'm agree that this is a very specific question that doesn't need to be merged to the complete module, but it is also not very practical IMHO if it doesn't add so much functionality. It will worth to have it if the module add also an agrupation by this category code in main analysis views that uses product as one axis, and other questions related to this new field (search views and so on).

Regards.

[Maxime Chambreuil (http://www.savoirfairelinux.com) (max3903)]

review: Approve (code review)

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

> I'm agree that this is a very specific question that doesn't need to be merged
> to the complete module, but it is also not very practical IMHO if it doesn't
> add so much functionality. It will worth to have it if the module add also an
> agrupation by this category code in main analysis views that uses product as
> one axis, and other questions related to this new field (search views and so
> on).
>
> Regards.

I agree.

At least if the module was a dependency for another existing module, I could see some interest to have it, otherwise, I'm not sure that we have a benefit to create small modules for adding 1 fields.

I won't block the MP if other people want to approve though so my voice is: abstain.

review: Abstain

[Joël Grand-Guillaume @ camptocamp (jgrandguillaume-c2c)]

Hi,

My opinion here also go in favor of Perdo's arguments. As long as the module "only" add a field, I'm not really in favor of approving that unless it really adds a feature on the field (like grouping on it in analysis view or whatever else).

So my vote goes for disapprove, mainly because we don't want to have hundreds of modules that "just" adds fields.

Regards,

Joël

review: Disapprove (code review, no tests)

[Lorenzo Battistini (elbati)]

Hi all, this MP can be rejected

review: Disapprove

[debaetsr (rubendebaets)]

Dear friend!

Here is some information that inspired me a lot, read it please, it may be helpful <http://action.getoffmylawnnow.com/e4jkqv>

Best wishes, ruben

Unmerged revisions

212. By Alex Comba - Agile BG on 2013-07-22

[FIX] copyright and version

211. By Alex Comba - Agile BG on 2013-07-22

[FIX] license

210. By Alex Comba - Agile BG on 2013-07-22

[REF] product_category_code module porting to 7.0

209. By Alex Comba - Agile BG on 2013-07-22

[ADD] product_category_code module 6.1 version

=== added directory 'product_category_code'
=== added file 'product_category_code/AUTHORS.txt'
--- product_category_code/AUTHORS.txt	1970-01-01 00:00:00 +0000
+++ product_category_code/AUTHORS.txt	2013-07-24 16:20:38 +0000
@@ -0,0 +1,2 @@
+Alex Comba <[e-mail]>
+Lorenzo Battistini <[e-mail]>

=== added file 'product_category_code/__init__.py'
--- product_category_code/__init__.py	1970-01-01 00:00:00 +0000
+++ product_category_code/__init__.py	2013-07-24 16:20:38 +0000
@@ -0,0 +1,22 @@
+# -*- coding: utf-8 -*-
+##############################################################################
+#
+#    OpenERP, Open Source Management Solution
+#    Copyright (C) 2011 Domsense s.r.l. (<http://www.domsense.com>).
+#    Copyright (C) 2013 Agile Business Group sagl (<http://www.agilebg.com>)
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as published
+#    by the Free Software Foundation, either version 3 of the License, or
+#    (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+import product

=== added file 'product_category_code/__openerp__.py'
--- product_category_code/__openerp__.py	1970-01-01 00:00:00 +0000
+++ product_category_code/__openerp__.py	2013-07-24 16:20:38 +0000
@@ -0,0 +1,38 @@
+# -*- coding: utf-8 -*-
+##############################################################################
+#
+#    OpenERP, Open Source Management Solution
+#    Copyright (C) 2011 Domsense s.r.l. (<http://www.domsense.com>).
+#    Copyright (C) 2013 Agile Business Group sagl (<http://www.agilebg.com>)
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as published
+#    by the Free Software Foundation, either version 3 of the License, or
+#    (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+{
+    "name": "Product Category Code",
+    "version": "1.0",
+    'category': 'Generic Modules/Inventory Control',
+    "description": """This module just adds 'code' field to product category""",
+    "author": "Agile Business Group",
+    'website': 'http://www.agilebg.com',
+    'license': 'AGPL-3',
+    "depends": [
+        "product"
+    ],
+    'data': [
+        'product_view.xml',
+    ],
+    'installable': True,
+    'active': False,
+}

=== added directory 'product_category_code/i18n'
=== added file 'product_category_code/i18n/it.po'
--- product_category_code/i18n/it.po	1970-01-01 00:00:00 +0000
+++ product_category_code/i18n/it.po	2013-07-24 16:20:38 +0000
@@ -0,0 +1,32 @@
+# Translation of OpenERP Server.
+# This file contains the translation of the following modules:
+#	* product_category_code
+#
+msgid ""
+msgstr ""
+"Project-Id-Version: OpenERP Server 6.0.2\n"
+"Report-Msgid-Bugs-To: [e-mail]\n"
+"POT-Creation-Date: 2011-07-05 14:37+0000\n"
+"PO-Revision-Date: 2011-07-05 16:37+0100\n"
+"Last-Translator: eLBati <[e-mail]>\n"
+"Language-Team: \n"
+"MIME-Version: 1.0\n"
+"Content-Type: text/plain; charset=UTF-8\n"
+"Content-Transfer-Encoding: 8bit\n"
+"Plural-Forms: \n"
+
+#. module: product_category_code
+#: constraint:product.category:0
+msgid "Error ! You can not create recursive categories."
+msgstr "Errore! Non si possono creare categorie ricorsive."
+
+#. module: product_category_code
+#: field:product.category,code:0
+msgid "Code"
+msgstr "Codice"
+
+#. module: product_category_code
+#: model:ir.model,name:product_category_code.model_product_category
+msgid "Product Category"
+msgstr "Categoria prodotto"
+

=== added file 'product_category_code/i18n/product_category_code.pot'
--- product_category_code/i18n/product_category_code.pot	1970-01-01 00:00:00 +0000
+++ product_category_code/i18n/product_category_code.pot	2013-07-24 16:20:38 +0000
@@ -0,0 +1,32 @@
+# Translation of OpenERP Server.
+# This file contains the translation of the following modules:
+#	* product_category_code
+#
+msgid ""
+msgstr ""
+"Project-Id-Version: OpenERP Server 6.0.2\n"
+"Report-Msgid-Bugs-To: [e-mail]\n"
+"POT-Creation-Date: 2011-07-05 14:36+0000\n"
+"PO-Revision-Date: 2011-07-05 14:36+0000\n"
+"Last-Translator: <>\n"
+"Language-Team: \n"
+"MIME-Version: 1.0\n"
+"Content-Type: text/plain; charset=UTF-8\n"
+"Content-Transfer-Encoding: \n"
+"Plural-Forms: \n"
+
+#. module: product_category_code
+#: constraint:product.category:0
+msgid "Error ! You can not create recursive categories."
+msgstr ""
+
+#. module: product_category_code
+#: field:product.category,code:0
+msgid "Code"
+msgstr ""
+
+#. module: product_category_code
+#: model:ir.model,name:product_category_code.model_product_category
+msgid "Product Category"
+msgstr ""
+

=== added file 'product_category_code/product.py'
--- product_category_code/product.py	1970-01-01 00:00:00 +0000
+++ product_category_code/product.py	2013-07-24 16:20:38 +0000
@@ -0,0 +1,31 @@
+# -*- coding: utf-8 -*-
+##############################################################################
+#
+#    OpenERP, Open Source Management Solution
+#    Copyright (C) 2011 Domsense s.r.l. (<http://www.domsense.com>).
+#    Copyright (C) 2013 Agile Business Group sagl (<http://www.agilebg.com>)
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as published
+#    by the Free Software Foundation, either version 3 of the License, or
+#    (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+
+from openerp.osv import fields, orm
+
+
+class product_category(orm.Model):
+    _inherit = "product.category"
+
+    _columns = {
+        'code': fields.char('Code', size=32),
+    }

=== added file 'product_category_code/product_view.xml'
--- product_category_code/product_view.xml	1970-01-01 00:00:00 +0000
+++ product_category_code/product_view.xml	2013-07-24 16:20:38 +0000
@@ -0,0 +1,20 @@
+<?xml version="1.0" encoding="utf-8"?>
+
+<openerp>
+    <data>
+        <record model="ir.ui.view" id="product_category_form_view_code">
+            <field name="name">product.category.form.code</field>
+            <field name="model">product.category</field>
+            <field name="inherit_id" ref="product.product_category_form_view"/>
+            <field name="arch" type="xml">
+                <xpath expr="/form/sheet/div/h1" position="after">
+                    <label for="code" class="oe_edit_only"/>
+                    <h1>
+                        <field name="code"/>
+                    </h1>
+                </xpath>
+            </field>
+        </record>
+    </data>
+</openerp>
+