Merge lp:~agilebg/openerp-icm/7.0_fix_sale_commission into lp:~openerp-icm/openerp-icm/7.0

Proposed by Alex Comba - Agile BG
Status: Merged
Merged at revision: 16
Proposed branch: lp:~agilebg/openerp-icm/7.0_fix_sale_commission
Merge into: lp:~openerp-icm/openerp-icm/7.0
Diff against target: 12 lines (+1/-1)
1 file modified
sale_commission/ (+1/-1)
To merge this branch: bzr merge lp:~agilebg/openerp-icm/7.0_fix_sale_commission
Reviewer Review Type Date Requested Status
Yajo (community) Approve
Davide Corio (community) Approve
Lorenzo Battistini (community) Approve
Maxime Chambreuil ( Approve
Pedro Manuel Baeza code review Approve
Review via email:

Description of the change

To post a comment you must log in.
Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :

Of course, very basic fix. I suppose that nobody has used this module yet. I'm going to start checking it on two weeks for one customer.


review: Approve (code review)
Revision history for this message
Maxime Chambreuil ( (max3903) :
review: Approve
Revision history for this message
Lorenzo Battistini (elbati) :
review: Approve
Revision history for this message
Davide Corio (enlightx-deactivatedaccount) wrote :

My bad, i submitted a wrong rev with the previous mp. but nobody noticed the issue ;-)

review: Approve
Revision history for this message
Yajo (yajo) wrote :

This allowed me to install the module.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'sale_commission/'
2--- sale_commission/ 2014-01-23 08:54:56 +0000
3+++ sale_commission/ 2014-02-06 14:49:11 +0000
4@@ -194,7 +194,7 @@
5 context = {}
6 partner_obj = self.pool.get('res.partner')
7 partner = settlement.agent_id.partner_id
8- return partner_obj.address_get(cr, uid, [], ['default', 'contact', 'invoice']), context=context)
9+ return partner_obj.address_get(cr, uid, [], ['default', 'contact', 'invoice'], context=context)
11 def _invoice_hook(self, cr, uid, picking, invoice_id, context=None):
12 '''Call after the creation of the invoice'''


People subscribed via source and target branches