Code review comment for lp:~agilebg/hr-timesheet/imp_hr_attendance_analysis_roundings

Revision history for this message
Yannick Vaucher @ Camptocamp (yvaucher-c2c) wrote :

Hello,

I think you can even use float_compare instead of float_is_zero. That way you can do the whole teste in one if.

http://bazaar.launchpad.net/~openerp/openobject-server/7.0/view/head:/openerp/tools/float_utils.py#L99

if float_compare(float_end_time, float_start_time, precision_rounding=0.0000001) == -1:

Cheers.

review: Needs Fixing

« Back to merge proposal