Merge lp:~agilebg/hr-timesheet/fix-hr_attendance_analysis-reference-is-not-defined into lp:~hr-core-editors/hr-timesheet/7.0

Proposed by Lorenzo Battistini on 2014-05-28
Status: Work in progress
Proposed branch: lp:~agilebg/hr-timesheet/fix-hr_attendance_analysis-reference-is-not-defined
Merge into: lp:~hr-core-editors/hr-timesheet/7.0
Diff against target: 12 lines (+1/-1)
1 file modified
hr_attendance_analysis/wizard/print_calendar_report.py (+1/-1)
To merge this branch: bzr merge lp:~agilebg/hr-timesheet/fix-hr_attendance_analysis-reference-is-not-defined
Reviewer Review Type Date Requested Status
Alex Comba - Agile BG (community) 2014-05-28 Disapprove on 2014-07-30
Pedro Manuel Baeza 2014-05-28 Resubmit on 2014-07-29
Review via email: mp+221250@code.launchpad.net

Description of the change

[FIX]
File "/home/elbati/workspace/openerp/progetti/agilebg/git/agilebg/parts/hr-timesheet-7.0/hr_attendance_analysis/wizard/print_calendar_report.py", line 160, in print_calendar
    for calendar_attendance in reference.attendance_ids:
NameError: global name 'reference' is not defined

To post a comment you must log in.
Pedro Manuel Baeza (pedro.baeza) wrote :

LGTM.

Regards.

review: Approve (code review)
69. By Alex Comba - Agile BG on 2014-07-11

[MRG] Merged upstream

Pedro Manuel Baeza (pedro.baeza) wrote :

This project is now hosted on https://github.com/OCA/hr-timesheet. Please move your proposal there. This guide may help you https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub

review: Resubmit
Alex Comba - Agile BG (tafaru) wrote :

Moved to https://github.com/OCA/hr-timesheet/pull/7
I prefer do not delete the proposal to keep all the associated comments that have been made.

review: Disapprove

Unmerged revisions

69. By Alex Comba - Agile BG on 2014-07-11

[MRG] Merged upstream

68. By Lorenzo Battistini on 2014-05-28

[FIX]
File "/home/elbati/workspace/openerp/progetti/agilebg/git/agilebg/parts/hr-timesheet-7.0/hr_attendance_analysis/wizard/print_calendar_report.py", line 160, in print_calendar
    for calendar_attendance in reference.attendance_ids:
NameError: global name 'reference' is not defined

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'hr_attendance_analysis/wizard/print_calendar_report.py'
2--- hr_attendance_analysis/wizard/print_calendar_report.py 2013-11-19 13:32:00 +0000
3+++ hr_attendance_analysis/wizard/print_calendar_report.py 2014-07-11 07:04:37 +0000
4@@ -157,7 +157,7 @@
5 if reference_calendar:
6 if reference_calendar.attendance_ids:
7 current_total_due = 0.0
8- for calendar_attendance in reference.attendance_ids:
9+ for calendar_attendance in reference_calendar.attendance_ids:
10 if ((
11 not calendar_attendance.dayofweek
12 or int(calendar_attendance.dayofweek) == current_date.weekday()

Subscribers

People subscribed via source and target branches