Merge lp:~agilebg/account-invoice-report/7_fix_1221570 into lp:~account-core-editors/account-invoice-report/7.0

Proposed by Lorenzo Battistini
Status: Merged
Approved by: Yannick Vaucher @ Camptocamp
Approved revision: 61
Merged at revision: 61
Proposed branch: lp:~agilebg/account-invoice-report/7_fix_1221570
Merge into: lp:~account-core-editors/account-invoice-report/7.0
Diff against target: 16 lines (+5/-1)
1 file modified
invoice_webkit/invoice_report.xml (+5/-1)
To merge this branch: bzr merge lp:~agilebg/account-invoice-report/7_fix_1221570
Reviewer Review Type Date Requested Status
Yannick Vaucher @ Camptocamp code review, no test Approve
Alexandre Fayolle - camptocamp code review, no tests Approve
Alex Comba - Agile BG (community) code review Approve
Pedro Manuel Baeza code review Approve
Review via email: mp+223781@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :

LGTM

review: Approve (code review)
Revision history for this message
Alex Comba - Agile BG (tafaru) :
review: Approve (code review)
Revision history for this message
Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c) wrote :

LGTM

review: Approve (code review, no tests)
Revision history for this message
Yannick Vaucher @ Camptocamp (yvaucher-c2c) wrote :

Thanks

LGTM

review: Approve (code review, no test)
Revision history for this message
Yannick Vaucher @ Camptocamp (yvaucher-c2c) wrote :

Thanks again Lorenzo, will be a time saver.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'invoice_webkit/invoice_report.xml'
--- invoice_webkit/invoice_report.xml 2012-12-04 14:19:45 +0000
+++ invoice_webkit/invoice_report.xml 2014-06-19 15:57:15 +0000
@@ -12,7 +12,11 @@
12 attachment="(object.state in ('open','paid')) and ('INV'+(object.number or '').replace('/',''))"12 attachment="(object.state in ('open','paid')) and ('INV'+(object.number or '').replace('/',''))"
13 attachment_use="1"13 attachment_use="1"
14 multi="True"14 multi="True"
15 webkit_header="base_headers_webkit.base_reports_portrait_header"
16 report_type="webkit"/>15 report_type="webkit"/>
17 </data>16 </data>
17 <data noupdate="1">
18 <record id="account.account_invoices" model="ir.actions.report.xml">
19 <field name="webkit_header" ref="base_headers_webkit.base_reports_portrait_header"></field>
20 </record>
21 </data>
18</openerp>22</openerp>

Subscribers

People subscribed via source and target branches