Merge lp:~agilebg/account-invoice-report/7.0-bug-1208389-elbati into lp:~account-core-editors/account-invoice-report/7.0

Proposed by Lorenzo Battistini
Status: Merged
Merged at revision: 39
Proposed branch: lp:~agilebg/account-invoice-report/7.0-bug-1208389-elbati
Merge into: lp:~account-core-editors/account-invoice-report/7.0
Diff against target: 12 lines (+1/-1)
1 file modified
invoice_webkit/report/account_invoice.mako (+1/-1)
To merge this branch: bzr merge lp:~agilebg/account-invoice-report/7.0-bug-1208389-elbati
Reviewer Review Type Date Requested Status
Stefan Rijnhart (Opener) Approve
Leonardo Pistone Approve
Guewen Baconnier @ Camptocamp Approve
Review via email: mp+178518@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Guewen Baconnier @ Camptocamp (gbaconnier-c2c) wrote :

LGTM

review: Approve
Revision history for this message
Leonardo Pistone (lepistone) wrote :

LGTM no test

review: Approve
Revision history for this message
Stefan Rijnhart (Opener) (stefan-opener) wrote :

Thanks! Merged with the target 7.0 branch. I checked the 6.1 series branch and I saw the bug does not apply as it already contains a similar line.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'invoice_webkit/report/account_invoice.mako'
2--- invoice_webkit/report/account_invoice.mako 2013-07-15 13:32:00 +0000
3+++ invoice_webkit/report/account_invoice.mako 2013-08-05 09:06:25 +0000
4@@ -273,7 +273,7 @@
5 <tbody>
6 %for line in inv.invoice_line :
7 <tr >
8- <td>${line.product_id and line.product_id.code or ''} ${line.product_id and line.product_id.name or ''}</td>
9+ <td>${line.name or ''}</td>
10 <td class="amount">${formatLang(line.quantity or 0.0,digits=get_digits(dp='Account'))}</td>
11 <td class="amount">${line.uos_id and line.uos_id.name or ''}</td>
12 <td class="amount">${formatLang(line.price_unit)}</td>

Subscribers

People subscribed via source and target branches