That said the module needs a general cleanup and review.
There is some oddities here and there and
a simple pass of the wizard file on flake 8 gave the following output:
select_template.py:3:2:warning: W291 trailing whitespace (python-flake8)
select_template.py:22:31:error: E231 missing whitespace after ',' (python-flake8)
select_template.py:23:1:warning: F401 'time' imported but unused (python-flake8)
select_template.py:26:1:error: E302 expected 2 blank lines, found 1 (python-flake8)
select_template.py:30:101:error: E501 line too long (102 > 100 characters) (python-flake8)
select_template.py:33:33:error: E231 missing whitespace after ',' (python-flake8)
select_template.py:38:17:error: E222 multiple spaces after operator (python-flake8)
select_template.py:46:48:error: E231 missing whitespace after ',' (python-flake8)
select_template.py:58:101:error: E501 line too long (117 > 100 characters) (python-flake8)
select_template.py:62:12:error: E121 continuation line indentation is not a multiple of four (python-flake8)
select_template.py:63:21:error: E203 whitespace before ':' (python-flake8)
select_template.py:76:1:warning: F841 local variable 'template_line_obj' is assigned to but never used (python-flake8)
select_template.py:77:1:warning: F841 local variable 'account_period_obj' is assigned to but never used (python-flake8)
select_template.py:81:1:warning: F841 local variable 'entry' is assigned to but never used (python-flake8)
select_template.py:83:17:error: E222 multiple spaces after operator (python-flake8)
select_template.py:105:24:error: E225 missing whitespace around operator (python-flake8)
select_template.py:108:46:error: E231 missing whitespace after ',' (python-flake8)
select_template.py:118:1:warning: F841 local variable 'id_line' is assigned to but never used (python-flake8)
select_template.py:132:35:error: E231 missing whitespace after ',' (python-flake8)
select_template.py:150:1:warning: W391 blank line at end of file (python-flake8)
Hello,
Thanks for the patch.
The diff looks good to me.
That said the module needs a general cleanup and review.
There is some oddities here and there and
a simple pass of the wizard file on flake 8 gave the following output:
select_ template. py:3:2: warning: W291 trailing whitespace (python-flake8) template. py:22:31: error: E231 missing whitespace after ',' (python-flake8) template. py:23:1: warning: F401 'time' imported but unused (python-flake8) template. py:26:1: error: E302 expected 2 blank lines, found 1 (python-flake8) template. py:30:101: error: E501 line too long (102 > 100 characters) (python-flake8) template. py:33:33: error: E231 missing whitespace after ',' (python-flake8) template. py:38:17: error: E222 multiple spaces after operator (python-flake8) template. py:46:48: error: E231 missing whitespace after ',' (python-flake8) template. py:58:101: error: E501 line too long (117 > 100 characters) (python-flake8) template. py:62:12: error: E121 continuation line indentation is not a multiple of four (python-flake8) template. py:63:21: error: E203 whitespace before ':' (python-flake8) template. py:76:1: warning: F841 local variable 'template_line_obj' is assigned to but never used (python-flake8) template. py:77:1: warning: F841 local variable 'account_ period_ obj' is assigned to but never used (python-flake8) template. py:81:1: warning: F841 local variable 'entry' is assigned to but never used (python-flake8) template. py:83:17: error: E222 multiple spaces after operator (python-flake8) template. py:105: 24:error: E225 missing whitespace around operator (python-flake8) template. py:108: 46:error: E231 missing whitespace after ',' (python-flake8) template. py:118: 1:warning: F841 local variable 'id_line' is assigned to but never used (python-flake8) template. py:132: 35:error: E231 missing whitespace after ',' (python-flake8) template. py:150: 1:warning: W391 blank line at end of file (python-flake8)
select_
select_
select_
select_
select_
select_
select_
select_
select_
select_
select_
select_
select_
select_
select_
select_
select_
select_
select_
Keep up the good work.
Regards
Nicolas