Merge lp:~agilebg/account-financial-report/fix_account_move_line_report_xls into lp:~account-report-core-editor/account-financial-report/7.0

Proposed by Alex Comba - Agile BG
Status: Rejected
Rejected by: Pedro Manuel Baeza
Proposed branch: lp:~agilebg/account-financial-report/fix_account_move_line_report_xls
Merge into: lp:~account-report-core-editor/account-financial-report/7.0
Diff against target: 18 lines (+8/-3)
1 file modified
account_move_line_report_xls/__init__.py (+8/-3)
To merge this branch: bzr merge lp:~agilebg/account-financial-report/fix_account_move_line_report_xls
Reviewer Review Type Date Requested Status
Pedro Manuel Baeza Disapprove
Review via email: mp+204500@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :
review: Disapprove
Revision history for this message
Alex Comba - Agile BG (tafaru) wrote :

Ok, I've just seen the corresponding merge.

Thanks, Pedro.

Unmerged revisions

72. By Alex Comba - Agile BG

[FIX] ImportError: No module named report_xls

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'account_move_line_report_xls/__init__.py'
2--- account_move_line_report_xls/__init__.py 2014-01-09 11:07:08 +0000
3+++ account_move_line_report_xls/__init__.py 2014-02-03 14:15:59 +0000
4@@ -19,6 +19,11 @@
5 # along with this program. If not, see <http://www.gnu.org/licenses/>.
6 #
7 ##############################################################################
8-
9-from . import account_move_line
10-from . import report
11+try:
12+ from . import account_move_line
13+ from . import report
14+except ImportError:
15+ import logging
16+ logging.getLogger('openerp.module').warning(
17+ 'report_xls not available in addons path.\
18+ account_financial_report_webkit_xls will not be usable')