Code review comment for lp:~agateau/unity-2d/move-bfb-to-launcher

Revision history for this message
Florian Boucault (fboucault) wrote :

Revision 627:

- we do not want to startup the dash when starting up the launcher (at login) in order to reduce the login time (remember all the efforts put in that last cycle?); look at placeentry.cpp for the strategy employed to avoid it
- in BfbItem::activate:
        m_dashInterface->call(QDBus::Block, "activateHome");

making the call blocking is not a good idea. Now that the proper monitoring of the active property will be in place, I suppose it won't be necessary anymore

- what happens if the dash dies for a reason or another, does the monitoring of the active property still work?

review: Needs Fixing

« Back to merge proposal