Ubuntu Developer Tools

Merge lp:~agateau/ubuntu-dev-tools/lp-project-upload-tarball-path into lp:~ubuntu-dev/ubuntu-dev-tools/trunk

  1. lp-project-upload-tarball-path
  2. Merge into trunk
Proposed by Aurélien Gâteau
Status: Merged
Merged at revision: 646
Proposed branch: lp:~agateau/ubuntu-dev-tools/lp-project-upload-tarball-path
Merge into: lp:~ubuntu-dev/ubuntu-dev-tools/trunk
Diff against target: 13 lines (+2/-1)
1 file modified
lp-project-upload (+2/-1)
To merge this branch: bzr merge lp:~agateau/ubuntu-dev-tools/lp-project-upload-tarball-path
Reviewer Review Type Date Requested Status
James Westby (community) Approve
Review via email: mp+26693@code.launchpad.net

Description of the change

If one uses lp-project-upload like this:

  lp-project-upload foo 1.0 build/foo-1.0.tar.bz2

Then the file on LP is named build-foo-1.0.tar.bz2.

Passing only the filename to the "release" object fixes it.

To post a comment you must log in.
Revision history for this message
James Westby (james-w) wrote :

Looks good to me.

Thanks,

James

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lp-project-upload'
2--- lp-project-upload 2009-11-20 22:59:00 +0000
3+++ lp-project-upload 2010-06-03 12:25:35 +0000
4@@ -98,7 +98,8 @@
5 signature_content = None
6
7 # Create a new product release file.
8- release.add_file(filename=tarball, description='release tarball',
9+ filename = os.path.basename(tarball)
10+ release.add_file(filename=filename, description='release tarball',
11 file_content=file_content, content_type='appplication/x-gzip',
12 file_type='Code Release Tarball', signature_filename=signature,
13 signature_content=signature_content)