Merge lp:~agateau/plasma-widget-message-indicator/fix-text-overlap-in-systemtray into lp:~kubuntu-packagers/kubuntu-packaging/plasma-widget-message-indicator

Proposed by Aurélien Gâteau
Status: Merged
Merged at revision: 6
Proposed branch: lp:~agateau/plasma-widget-message-indicator/fix-text-overlap-in-systemtray
Merge into: lp:~kubuntu-packagers/kubuntu-packaging/plasma-widget-message-indicator
Diff against target: 45 lines (+27/-0)
3 files modified
debian/changelog (+7/-0)
debian/patches/kubuntu_02_fix_text_overlap_in_systemtray.diff (+19/-0)
debian/patches/series (+1/-0)
To merge this branch: bzr merge lp:~agateau/plasma-widget-message-indicator/fix-text-overlap-in-systemtray
Reviewer Review Type Date Requested Status
Aurélien Gâteau Pending
Review via email: mp+37106@code.launchpad.net

Description of the change

Work around for LP #632419. The real fix is in lp:libindicate-qt/trunk, but I'd rather not get new versions of libraries out that close to Maverick release.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2010-09-08 18:49:55 +0000
3+++ debian/changelog 2010-09-30 08:03:44 +0000
4@@ -1,3 +1,10 @@
5+plasma-widget-message-indicator (0.5.6-0ubuntu3) maverick; urgency=low
6+
7+ * Add kubuntu_02_fix_text_overlap_in_systemtray.diff to work around text
8+ overlap in system tray LP: #632419
9+
10+ -- Aurélien Gâteau <aurelien.gateau@canonical.com> Thu, 30 Sep 2010 09:47:14 +0200
11+
12 plasma-widget-message-indicator (0.5.6-0ubuntu2) maverick; urgency=low
13
14 * Add kubuntu_01_fix_translation_domain.diff to create the correct
15
16=== added file 'debian/patches/kubuntu_02_fix_text_overlap_in_systemtray.diff'
17--- debian/patches/kubuntu_02_fix_text_overlap_in_systemtray.diff 1970-01-01 00:00:00 +0000
18+++ debian/patches/kubuntu_02_fix_text_overlap_in_systemtray.diff 2010-09-30 08:03:44 +0000
19@@ -0,0 +1,19 @@
20+This patch should be removed when libindicate-qt 0.2.6 is out. But since we are
21+very close to Maverick release I prefer to patch the applet than the library.
22+Index: plasma-widget-message-indicator-0.5.6/src/message-indicator.cpp
23+===================================================================
24+--- plasma-widget-message-indicator-0.5.6.orig/src/message-indicator.cpp 2010-09-30 09:45:36.000000000 +0200
25++++ plasma-widget-message-indicator-0.5.6/src/message-indicator.cpp 2010-09-30 09:46:09.000000000 +0200
26+@@ -127,10 +127,10 @@
27+ // from "messaging" to "message.<something>"
28+ mSourceModel = new ListenerModel(mListener, QRegExp("^messag(e|ing)"));
29+ connect(mSourceModel, SIGNAL(rowsInserted(const QModelIndex&, int, int)),
30+- SLOT(slotRowsChanged(const QModelIndex&))
31++ SLOT(slotRowsChanged(const QModelIndex&)), Qt::QueuedConnection
32+ );
33+ connect(mSourceModel, SIGNAL(rowsRemoved(const QModelIndex&, int, int)),
34+- SLOT(slotRowsChanged(const QModelIndex&))
35++ SLOT(slotRowsChanged(const QModelIndex&)), Qt::QueuedConnection
36+ );
37+ connect(mSourceModel, SIGNAL(drawAttentionChanged(const QModelIndex&)),
38+ SLOT(slotDrawAttentionChanged())
39
40=== modified file 'debian/patches/series'
41--- debian/patches/series 2010-09-08 18:49:55 +0000
42+++ debian/patches/series 2010-09-30 08:03:44 +0000
43@@ -1,1 +1,2 @@
44 kubuntu_01_fix_translation_domain.diff
45+kubuntu_02_fix_text_overlap_in_systemtray.diff

Subscribers

People subscribed via source and target branches