Merge lp:~agateau/pbuilder/pbuilder-hooks-own-repo-fixes into lp:~kubuntu-packagers/pbuilder/pbuilder-hooks

Proposed by Aurélien Gâteau
Status: Needs review
Proposed branch: lp:~agateau/pbuilder/pbuilder-hooks-own-repo-fixes
Merge into: lp:~kubuntu-packagers/pbuilder/pbuilder-hooks
Diff against target: 40 lines (+5/-4)
2 files modified
D09custompool (+4/-3)
README (+1/-1)
To merge this branch: bzr merge lp:~agateau/pbuilder/pbuilder-hooks-own-repo-fixes
Reviewer Review Type Date Requested Status
Harald Sitter Pending
Review via email: mp+83979@code.launchpad.net

Description of the change

Some fixes for the custom pool hook

To post a comment you must log in.

Unmerged revisions

31. By Aurélien Gâteau

Fix typo (POOLDDIR => POOLDIR) and output a few informative messages.

30. By Aurélien Gâteau

Created repo is a trivial repo, the 'deb' line should only have two parameters

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'D09custompool'
2--- D09custompool 2010-12-13 20:47:00 +0000
3+++ D09custompool 2011-11-30 17:06:26 +0000
4@@ -1,8 +1,8 @@
5 #!/bin/sh
6
7 if [ $POOL ]; then
8- if [ -z $POOLDIR ]; then
9- POOLDDIR=/usr/src/deb/pool
10+ if [ -z "$POOLDIR" ]; then
11+ POOLDIR=/usr/src/deb/pool
12 fi
13
14 cd $POOLDIR
15@@ -12,10 +12,11 @@
16 fi
17
18 d=`pwd`
19- echo $d
20+ echo "POOLDIR=$d"
21 grep "$d" /etc/apt/sources.list > /dev/null 2>&1
22
23 if [ "$?" != "0" ]; then
24+ echo "POOLDIR not found in /etc/apt/sources.list, adding it"
25 echo "deb file:$d ./" >> /etc/apt/sources.list
26 echo "APT::Get::AllowUnauthenticated 1;" >> /etc/apt/apt.conf.d/allow-unauthenticated
27
28
29=== modified file 'README'
30--- README 2010-09-02 20:03:33 +0000
31+++ README 2011-11-30 17:06:26 +0000
32@@ -58,7 +58,7 @@
33 used above. IMHO it actually makes sense to write a script for post_upload.
34
35 * Once all is set up properly you should be able to use
36- deb file:/usr/src/deb/pool/jaunty jaunty ./
37+ deb file:/usr/src/deb/pool/jaunty ./
38 to use your package pool. It makes sense to change pbuilder's sources.list
39 (sudo pbuilder login --save-after-login). If you don't add it manually, the
40 hook will add it every time again and run the scan to make sure the

Subscribers

People subscribed via source and target branches