Merge lp:~agateau/libdbusmenu/fix-gtk3-warnings into lp:libdbusmenu/0.6

Proposed by Aurélien Gâteau
Status: Rejected
Rejected by: Aurélien Gâteau
Proposed branch: lp:~agateau/libdbusmenu/fix-gtk3-warnings
Merge into: lp:libdbusmenu/0.6
Diff against target: 27 lines (+8/-0)
1 file modified
libdbusmenu-gtk/genericmenuitem.c (+8/-0)
To merge this branch: bzr merge lp:~agateau/libdbusmenu/fix-gtk3-warnings
Reviewer Review Type Date Requested Status
Ted Gould Pending
Review via email: mp+89682@code.launchpad.net

Description of the change

Building the gtk3 version of dbusmenu fails by default because gtk3 deprecated warnings are turned into errors with -Werror.

To post a comment you must log in.
Revision history for this message
Mikkel Kamstrup Erlandsen (kamstrup) wrote :
Revision history for this message
Aurélien Gâteau (agateau) wrote :

Oups, cancelling then :)

Unmerged revisions

347. By Aurélien Gâteau

Fix build of the gtk3 version

gtk_hbox_new() is deprecated => building fails because of -Werror

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'libdbusmenu-gtk/genericmenuitem.c'
2--- libdbusmenu-gtk/genericmenuitem.c 2011-10-05 18:59:21 +0000
3+++ libdbusmenu-gtk/genericmenuitem.c 2012-01-23 13:47:29 +0000
4@@ -241,7 +241,11 @@
5 /* We need to put the child into a new box and
6 make the box the child of the menu item. Basically
7 we're inserting a box in the middle. */
8+#if GTK_CHECK_VERSION(3, 0, 0)
9+ GtkWidget * hbox = gtk_box_new(GTK_ORIENTATION_HORIZONTAL, get_toggle_space(GTK_WIDGET(menu_item)));
10+#else
11 GtkWidget * hbox = gtk_hbox_new(FALSE, get_toggle_space(GTK_WIDGET(menu_item)));
12+#endif
13 g_object_ref(child);
14 gtk_container_remove(GTK_CONTAINER(menu_item), child);
15 gtk_box_pack_start(GTK_BOX(hbox), child, FALSE, FALSE, 0);
16@@ -457,7 +461,11 @@
17 /* We need to put the child into a new box and
18 make the box the child of the menu item. Basically
19 we're inserting a box in the middle. */
20+#if GTK_CHECK_VERSION(3, 0, 0)
21+ GtkWidget * hbox = gtk_box_new(GTK_ORIENTATION_HORIZONTAL, get_toggle_space(GTK_WIDGET(menu_item)));
22+#else
23 GtkWidget * hbox = gtk_hbox_new(FALSE, get_toggle_space(GTK_WIDGET(menu_item)));
24+#endif
25 g_object_ref(child);
26 gtk_container_remove(GTK_CONTAINER(menu_item), child);
27 gtk_box_pack_end(GTK_BOX(hbox), child, TRUE, TRUE, 0);

Subscribers

People subscribed via source and target branches