Merge lp:~agateau/checkbox/progress-bar into lp:checkbox
Proposed by
Aurélien Gâteau
Status: | Merged |
---|---|
Merge reported by: | Daniel Manrique |
Merged at revision: | not available |
Proposed branch: | lp:~agateau/checkbox/progress-bar |
Merge into: | lp:checkbox |
Diff against target: |
69 lines (+26/-3) 3 files modified
checkbox_gtk/gtk_interface.py (+6/-0) gtk/checkbox-gtk.ui (+16/-3) plugins/jobs_prompt.py (+4/-0) |
To merge this branch: | bzr merge lp:~agateau/checkbox/progress-bar |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Daniel Manrique (community) | Approve | ||
Brendan Donegan (community) | Needs Fixing | ||
Review via email: mp+92304@code.launchpad.net |
Description of the change
This branch adds a progress bar to the main test window, showing how many tests remain to be run. The changes in the .ui looks heavy but it's just glade rewriting things: it just replace the GtkButtonBox holding the Test button with a GtkBox and inserts a GtkProgressBar to the left of the Test button.
To post a comment you must log in.
Thanks, this is awesome! It's easily one of the top five features requested in Checkbox.
Checkbox rev 1109 also had some rearranging of components in Glade, but Glade really made a mess of the XML files for what was meant to be a simple change. What I did was make the changes manually in the XML file and the patch came out much cleaner. If you have a moment, could you see if it's possible to do this here? If not, don't worry, I'll probably look into doing it manually myself and then test that all works well.
Thanks again, much appreciated.