Merge lp:~agateau/amarok/appmenu-fix into lp:~kubuntu-packagers/kubuntu-packaging/amarok

Proposed by Aurélien Gâteau
Status: Merged
Approved by: Alessandro Ghersi
Approved revision: 66
Merge reported by: Felix Geyer
Merged at revision: not available
Proposed branch: lp:~agateau/amarok/appmenu-fix
Merge into: lp:~kubuntu-packagers/kubuntu-packaging/amarok
Diff against target: 27 lines (+15/-0)
2 files modified
debian/patches/kubuntu/12_appmenu_fix.diff (+14/-0)
debian/patches/series (+1/-0)
To merge this branch: bzr merge lp:~agateau/amarok/appmenu-fix
Reviewer Review Type Date Requested Status
Felix Geyer Approve
VCS imports Pending
Review via email: mp+35428@code.launchpad.net

Description of the change

When running Amarok with the appmenu Plasma widget, make sure going to "Internet > Magnatune" or any other service does not replace the menubar with a weird one-entry menubar.

To post a comment you must log in.
Revision history for this message
Felix Geyer (debfx) wrote :

Looks good!
I manually merged it as the bzr branches are somehow not compatible.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added file 'debian/patches/kubuntu/12_appmenu_fix.diff'
2--- debian/patches/kubuntu/12_appmenu_fix.diff 1970-01-01 00:00:00 +0000
3+++ debian/patches/kubuntu/12_appmenu_fix.diff 2010-09-14 15:39:46 +0000
4@@ -0,0 +1,14 @@
5+Prevent the appmenu menubar from being replaced by a strange single entry
6+menubar when browsing Internet services.
7+Index: amarok-2.3.1/src/services/ServiceBase.cpp
8+===================================================================
9+--- amarok-2.3.1.orig/src/services/ServiceBase.cpp 2010-09-14 17:19:40.000000000 +0200
10++++ amarok-2.3.1/src/services/ServiceBase.cpp 2010-09-14 17:20:05.000000000 +0200
11+@@ -140,6 +140,7 @@
12+ m_filterModel->setFilterCaseSensitivity( Qt::CaseInsensitive );
13+
14+ m_menubar = new KMenuBar( m_topPanel );
15++ m_menubar->setNativeMenuBar( false );
16+ m_filterMenu = m_menubar->addMenu( i18n( "Group By" ) );
17+
18+ m_menubar->hide();
19
20=== modified file 'debian/patches/series'
21--- debian/patches/series 2010-08-26 14:51:10 +0000
22+++ debian/patches/series 2010-09-14 15:39:46 +0000
23@@ -5,3 +5,4 @@
24 kubuntu/08_fix_handbook_install_location.diff
25 kubuntu/10_soundmenu_support.diff
26 kubuntu/11_soundmenu_mpris2.0.diff
27+kubuntu/12_appmenu_fix.diff

Subscribers

People subscribed via source and target branches