Merge lp:~afroyd/charms/trusty/zend-server/zend-server-8-GA into lp:charms/trusty/zend-server

Proposed by afroyd
Status: Merged
Merged at revision: 2
Proposed branch: lp:~afroyd/charms/trusty/zend-server/zend-server-8-GA
Merge into: lp:charms/trusty/zend-server
Diff against target: 29 lines (+2/-3)
2 files modified
hooks/config-changed (+1/-1)
hooks/install (+1/-2)
To merge this branch: bzr merge lp:~afroyd/charms/trusty/zend-server/zend-server-8-GA
Reviewer Review Type Date Requested Status
José Antonio Rey (community) Approve
Review Queue (community) automated testing Needs Fixing
Review via email: mp+244421@code.launchpad.net

Description of the change

Changing the installation source from the Beta version to the newly released GA version

To post a comment you must log in.
Revision history for this message
Review Queue (review-queue) wrote :

This items has failed automated testing! Results available here http://reports.vapour.ws/charm-tests/charm-bundle-test-10689-results

review: Needs Fixing (automated testing)
Revision history for this message
José Antonio Rey (jose) wrote :

Hello, Amir!

Thank you for proposing this fix for the Zend Server charm. Turns out I ran automated testing on my end (EC2) and it passes with no errors!

I will be merging this in a couple minutes since it looks sane enough and the deployment works as expected. Thanks again for the fix!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added file 'files/ZendServer-8.0.0-RepositoryInstaller-linux.tar.gz'
2Binary files files/ZendServer-8.0.0-RepositoryInstaller-linux.tar.gz 1970-01-01 00:00:00 +0000 and files/ZendServer-8.0.0-RepositoryInstaller-linux.tar.gz 2014-12-11 12:33:01 +0000 differ
3=== removed file 'files/repo_installer_beta.tar.gz'
4Binary files files/repo_installer_beta.tar.gz 2014-11-12 22:26:14 +0000 and files/repo_installer_beta.tar.gz 1970-01-01 00:00:00 +0000 differ
5=== removed file 'files/repo_installer_early_access.tar.gz'
6Binary files files/repo_installer_early_access.tar.gz 2014-11-12 22:26:14 +0000 and files/repo_installer_early_access.tar.gz 1970-01-01 00:00:00 +0000 differ
7=== modified file 'hooks/config-changed'
8--- hooks/config-changed 2014-11-12 22:26:14 +0000
9+++ hooks/config-changed 2014-12-11 12:33:01 +0000
10@@ -9,7 +9,7 @@
11 production="true"
12 private_address=`ip addr | grep 'state UP' -A2 | tail -n1 | awk '{print $2}' | cut -f1 -d'/'`
13 if [ "$ZS_installed" = "false" ]; then
14- ./install_zs.sh $phpVersion --automatic
15+ ./ZendServer-RepositoryInstaller-linux/install_zs.sh $phpVersion --automatic
16 juju-log "Zend Server installed. Will now proceed to bootstrap if api key hash is available"
17 echo "ZS_installed=true" >> ~/.ZendServerStatus
18 fi
19
20=== modified file 'hooks/install'
21--- hooks/install 2014-11-12 22:26:14 +0000
22+++ hooks/install 2014-12-11 12:33:01 +0000
23@@ -1,5 +1,4 @@
24 #!/bin/bash
25 set -ex # If any command fails, stop execution of the hook with that error
26 echo "ZS_installed=false" >> ~/.ZendServerStatus
27-#tar xzf files/repo_installer_early_access.tar.gz
28-tar xzf files/repo_installer_beta.tar.gz
29+tar xzf files/ZendServer-8.0.0-RepositoryInstaller-linux.tar.gz

Subscribers

People subscribed via source and target branches

to all changes: