Merge ~afreiberger/charm-prometheus-grok-exporter:lp1912847-add-ovs-grok-patterns into charm-prometheus-grok-exporter:master

Proposed by Drew Freiberger
Status: Merged
Approved by: James Troup
Approved revision: 051ca94de39515724ee2e664c5ff10a3ba53100a
Merged at revision: d9f54a98ffcd686fd44e12b770d8d98305212462
Proposed branch: ~afreiberger/charm-prometheus-grok-exporter:lp1912847-add-ovs-grok-patterns
Merge into: charm-prometheus-grok-exporter:master
Diff against target: 45 lines (+27/-1)
2 files modified
src/files/grok-patterns.yaml (+2/-0)
src/files/metrics-mapping.yaml (+25/-1)
Reviewer Review Type Date Requested Status
Tom Haddon Abstain
🤖 prod-jenkaas-bootstack (community) continuous-integration Approve
BootStack Reviewers Pending
Review via email: mp+401421@code.launchpad.net

Commit message

Add Openvswitch log patterns and metrics.

To post a comment you must log in.
Revision history for this message
🤖 prod-jenkaas-bootstack (prod-jenkaas-bootstack) wrote :

A CI job is currently in progress. A follow up comment will be added when it completes.

Revision history for this message
🤖 prod-jenkaas-bootstack (prod-jenkaas-bootstack) wrote :

FAILED: Continuous integration, rev:051ca94de39515724ee2e664c5ff10a3ba53100a

No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want jenkins to rebuild you need to trigger it yourself):
https://code.launchpad.net/~afreiberger/charm-prometheus-grok-exporter/+git/charm-prometheus-grok-exporter/+merge/401421/+edit-commit-message

https://jenkins.canonical.com/bootstack/job/lp-charm-prometheus-grok-exporter-ci/1/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/bootstack/job/lp-charm-test-unit/47/
    None: https://jenkins.canonical.com/bootstack/job/lp-update-mp/134/

Click here to trigger a rebuild:
https://jenkins.canonical.com/bootstack/job/lp-charm-prometheus-grok-exporter-ci/1//rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
🤖 prod-jenkaas-bootstack (prod-jenkaas-bootstack) wrote :
review: Approve (continuous-integration)
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
Tom Haddon (mthaddon) wrote :

Abstaining, just claimed the review to take it off the canonical-is-reviewers dashboard, mergebot has been switched to add bootstack-reviewers for future MPs.

review: Abstain
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision d9f54a98ffcd686fd44e12b770d8d98305212462

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/src/files/grok-patterns.yaml b/src/files/grok-patterns.yaml
2index bb180d9..1a14d2d 100644
3--- a/src/files/grok-patterns.yaml
4+++ b/src/files/grok-patterns.yaml
5@@ -3,3 +3,5 @@ grok_patterns:
6 API_ACCESS: '(%{NOTSPACE:service}%{SPACE})?%{NOTSPACE:requesterip}%{SPACE}-%{SPACE}-%{SPACE}\[%{HTTPDATE:logdate}\]%{SPACE}\"%{NOTSPACE:http_verb}%{SPACE}%{NOTSPACE:url}%{SPACE}%{NOTSPACE:http_version}\"%{SPACE}%{NUMBER:response}%{SPACE}%{NUMBER:response_len}%{GREEDYDATA:client}\"?'
7 NOVA_COMPUTE: '%{TIMESTAMP_ISO8601:logdate}%{SPACE}%{NUMBER:pid}?%{SPACE}?%{LOGLEVEL:loglevel}%{SPACE}((\[)?(%{NOTSPACE:module})?(\])?%{SPACE})?\[%{GREEDYDATA:request}\]%{SPACE}\[%{GREEDYDATA:resource}\]%{SPACE}%{GREEDYDATA:logmessage}'
8 OPENSTACK_ERROR: '%{TIMESTAMP_ISO8601:logdate}%{SPACE}(\[)?%{NUMBER:pid}?(\])?%{SPACE}ERROR%{GREEDYDATA:message}'
9+ OPENVSWITCH_ERRORS: '%{TIMESTAMP_ISO8601:logdate}\|%{NUMBER:logline}\|%{NOTSPACE:module}\|ERR\|%{GREEDYDATA:message}'
10+ OPENVSWITCH_NOT_SUPPORTED: '%{TIMESTAMP_ISO8601:logdate}\|%{NUMBER:logline}\|%{NOTSPACE:module}\|%{LOGLEVEL:loglevel}\|(?<message>.*?[Nn]ot [Ss]upported.*)'
11diff --git a/src/files/metrics-mapping.yaml b/src/files/metrics-mapping.yaml
12index b74c8d0..096039f 100644
13--- a/src/files/metrics-mapping.yaml
14+++ b/src/files/metrics-mapping.yaml
15@@ -246,4 +246,28 @@ metrics:
16 help: Total number of gnocchi access api calls grouped by response code
17 match: '%{API_ACCESS}'
18 labels:
19- response_code: '{{.response}}'
20\ No newline at end of file
21+ response_code: '{{.response}}'
22+ openvswitch_ovs_vswitchd_errors:
23+ type: counter
24+ path: /var/log/openvswitch/ovs-vswitchd.log
25+ help: Total number of ovs-vswitchd errors
26+ match: '%{OPENVSWITCH_ERRORS}'
27+ labels:
28+ module: '{{.module}}'
29+ message: '{{.message}}'
30+ openvswitch_ovs_vswitchd_unsupported:
31+ type: counter
32+ path: /var/log/openvswitch/ovs-vswitchd.log
33+ help: Total number of ovs-vswitchd not supported log entries
34+ match: '%{OPENVSWITCH_NOT_SUPPORTED}'
35+ labels:
36+ module: '{{.module}}'
37+ message: '{{.message}}'
38+ openvswitch_ovsdb_server_errors:
39+ type: counter
40+ path: /var/log/openvswitch/ovsdb-server.log
41+ help: Total number of ovsdb-server errors
42+ match: '%{OPENVSWITCH_ERRORS}'
43+ labels:
44+ module: '{{.module}}'
45+ message: '{{.message}}'

Subscribers

People subscribed via source and target branches

to all changes: