Merge ~afreiberger/charm-openstack-service-checks/+git/charm-openstack-service-checks:lp1818113 into ~canonical-bootstack/charm-openstack-service-checks:master

Proposed by Drew Freiberger
Status: Merged
Approved by: Alvaro Uria
Approved revision: 269e62befb76e0d4e2b3c6de62ce2a1ba79d1aa7
Merged at revision: 11f2a702444d5b45c84a667a69db11011dbdc88b
Proposed branch: ~afreiberger/charm-openstack-service-checks/+git/charm-openstack-service-checks:lp1818113
Merge into: ~canonical-bootstack/charm-openstack-service-checks:master
Diff against target: 31 lines (+1/-3)
2 files modified
layer.yaml (+0/-2)
reactive/service_checks.py (+1/-1)
Reviewer Review Type Date Requested Status
Alvaro Uria (community) Approve
Review via email: mp+364009@code.launchpad.net

Commit message

Resolved race condition with keystoneauth1 module import

    Using layer:basic imports apt packages during bootstrap before
    any reactive handlers are called. removed layer:apt

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
Alvaro Uria (aluria) wrote :

lgtm

review: Approve
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision 11f2a702444d5b45c84a667a69db11011dbdc88b

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/layer.yaml b/layer.yaml
2index 72f0af5..92676ed 100644
3--- a/layer.yaml
4+++ b/layer.yaml
5@@ -1,5 +1,4 @@
6 includes:
7- - 'layer:apt'
8 - 'layer:basic'
9 - 'interface:keystone-credentials'
10 - 'interface:nrpe-external-master'
11@@ -8,7 +7,6 @@ repo: 'lp:~canonical-bootstack/+git/charm-openstack-service-checks'
12 options:
13 basic:
14 use_venv: true
15- apt:
16 packages:
17 - nagios-nrpe-server
18 - python3-keystoneclient
19diff --git a/reactive/service_checks.py b/reactive/service_checks.py
20index 9805f77..5355c6f 100644
21--- a/reactive/service_checks.py
22+++ b/reactive/service_checks.py
23@@ -28,7 +28,7 @@ PLUGINS_DIR = '/usr/local/lib/nagios/plugins/'
24
25 @when_not('os-service-checks.installed')
26 def install_service_checks():
27- # Apt package installs are handled by the apt layer
28+ # Apt package installs are handled by the basic layer
29 set_state('os-service-checks.installed')
30 remove_state('os-service-checks.configured')
31 hookenv.status_set('active', 'Ready')

Subscribers

People subscribed via source and target branches