Merge lp:~afrantzis/unity-system-compositor/non-blocking-swap-buffers into lp:unity-system-compositor

Proposed by Alexandros Frantzis
Status: Merged
Approved by: Gerry Boland
Approved revision: 129
Merged at revision: 132
Proposed branch: lp:~afrantzis/unity-system-compositor/non-blocking-swap-buffers
Merge into: lp:unity-system-compositor
Diff against target: 19 lines (+2/-6)
1 file modified
src/dbus_screen.cpp (+2/-6)
To merge this branch: bzr merge lp:~afrantzis/unity-system-compositor/non-blocking-swap-buffers
Reviewer Review Type Date Requested Status
Gerry Boland (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+214759@code.launchpad.net

Commit message

Keep the compositor running even when the screen is turned off

This is needed so that the compositor can consume surface buffers and
prevent clients from blocking in eglSwapBuffers().

Description of the change

Keep the compositor running even when the screen is turned off

This is needed so that the compositor can consume surface buffers and
prevent clients from blocking in eglSwapBuffers().

Related Mir MPs:
https://code.launchpad.net/~afrantzis/mir/non-blocking-swap-buffers/+merge/214755
https://code.launchpad.net/~afrantzis/mir/expose-display-buffer-only-for-power-mode-on/+merge/214758

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Gerry Boland (gerboland) wrote :

This did the trick when I tested last week

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/dbus_screen.cpp'
2--- src/dbus_screen.cpp 2014-03-17 14:57:50 +0000
3+++ src/dbus_screen.cpp 2014-04-08 13:41:00 +0000
4@@ -40,13 +40,9 @@
5 }
6 );
7
8- if (mode != MirPowerMode::mir_power_mode_on)
9- compositor->stop();
10-
11+ compositor->stop();
12 display->configure(*displayConfig.get());
13-
14- if (mode == MirPowerMode::mir_power_mode_on)
15- compositor->start();
16+ compositor->start();
17 }
18
19 // Note: this class should be created only after when the Mir DisplayServer has started

Subscribers

People subscribed via source and target branches