Mir

Merge lp:~afrantzis/mir/work-around-glm-initializer-list-breakage into lp:mir

Proposed by Alexandros Frantzis
Status: Merged
Approved by: kevin gunn
Approved revision: no longer in the source branch.
Merged at revision: 1433
Proposed branch: lp:~afrantzis/mir/work-around-glm-initializer-list-breakage
Merge into: lp:mir
Diff against target: 47 lines (+4/-4)
3 files modified
examples/render_surfaces.cpp (+1/-1)
src/server/compositor/gl_renderer.cpp (+1/-1)
src/server/scene/basic_surface.cpp (+2/-2)
To merge this branch: bzr merge lp:~afrantzis/mir/work-around-glm-initializer-list-breakage
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Alberto Aguirre (community) Approve
Review via email: mp+208670@code.launchpad.net

Commit message

Work around GLM initializer list breakage

These problems have been fixed in GLM 0.9.5.2:
  https://github.com/g-truc/glm/issues/159
  https://github.com/g-truc/glm/issues/160
...but until then we can work around them.

Description of the change

Work around GLM initializer list breakage

These problems have been fixed in GLM 0.9.5.2:

  https://github.com/g-truc/glm/issues/159
  https://github.com/g-truc/glm/issues/160

...but until we update GLM in the archive we can work around them.

To post a comment you must log in.
Revision history for this message
Alberto Aguirre (albaguirre) :
review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'examples/render_surfaces.cpp'
2--- examples/render_surfaces.cpp 2014-02-26 10:14:37 +0000
3+++ examples/render_surfaces.cpp 2014-02-27 18:41:06 +0000
4@@ -199,7 +199,7 @@
5 h{static_cast<float>(s->size().height.as_uint32_t())},
6 dx{dx},
7 dy{dy},
8- rotation_axis{rotation_axis},
9+ rotation_axis(rotation_axis),
10 alpha_offset{alpha_offset}
11 {
12 }
13
14=== modified file 'src/server/compositor/gl_renderer.cpp'
15--- src/server/compositor/gl_renderer.cpp 2014-02-14 09:45:44 +0000
16+++ src/server/compositor/gl_renderer.cpp 2014-02-27 18:41:06 +0000
17@@ -289,7 +289,7 @@
18 * (top-left is (0,0), bottom-right is (W,H)) to the normalized GL coordinate system
19 * (top-left is (-1,1), bottom-right is (1,-1))
20 */
21- glm::mat4 screen_to_gl_coords = glm::translate(glm::mat4{1.0f}, glm::vec3{-1.0f, 1.0f, 0.0f});
22+ glm::mat4 screen_to_gl_coords = glm::translate(glm::mat4(1.0f), glm::vec3{-1.0f, 1.0f, 0.0f});
23 screen_to_gl_coords = glm::scale(screen_to_gl_coords,
24 glm::vec3{2.0f / rect.size.width.as_float(),
25 -2.0f / rect.size.height.as_float(),
26
27=== modified file 'src/server/scene/basic_surface.cpp'
28--- src/server/scene/basic_surface.cpp 2014-02-26 05:22:52 +0000
29+++ src/server/scene/basic_surface.cpp 2014-02-27 18:41:06 +0000
30@@ -241,7 +241,7 @@
31 {
32 {
33 std::unique_lock<std::mutex> lk(guard);
34- rotation_matrix = glm::rotate(glm::mat4{1.0f}, degrees, axis);
35+ rotation_matrix = glm::rotate(glm::mat4(1.0f), degrees, axis);
36 transformation_dirty = true;
37 }
38 notify_change();
39@@ -263,7 +263,7 @@
40 0.0f};
41
42 /* Get the center of the renderable's area */
43- const glm::vec3 center_vec{top_left_vec + 0.5f * size_vec};
44+ const glm::vec3 center_vec(top_left_vec + 0.5f * size_vec);
45
46 /*
47 * Every renderable is drawn using a 1x1 quad centered at 0,0.

Subscribers

People subscribed via source and target branches