Mir

Merge lp:~afrantzis/mir/fix-mircommon-debian-replaces into lp:mir

Proposed by Alexandros Frantzis
Status: Superseded
Proposed branch: lp:~afrantzis/mir/fix-mircommon-debian-replaces
Merge into: lp:mir
Diff against target: 25 lines (+4/-4)
1 file modified
debian/control (+4/-4)
To merge this branch: bzr merge lp:~afrantzis/mir/fix-mircommon-debian-replaces
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Alexandros Frantzis (community) Needs Fixing
Alan Griffiths Needs Fixing
Kevin DuBois (community) Abstain
Review via email: mp+228247@code.launchpad.net

Commit message

debian: Replace any version of mircommon-dev with libmircommon-dev

Description of the change

debian: Replace any version of mircommon-dev with libmircommon-dev

Our previous scheme only replaced mircommon-dev up to a specific version, but we have since moved to a newer mircommon-dev version.

To post a comment you must log in.
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

LGTM (but what do I know)

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

Would a purist prefer "(< 0.6)"?

Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

> dpkg: dependency problems prevent configuration of mircommon-dev:armhf:
> libmircommon-dev:armhf (0.6.0bzr1792pkg0utopic5+autopilot0) breaks mircommon-dev and is installed.
>
> dpkg: error processing package mircommon-dev:armhf (--install):
> dependency problems - leaving unconfigured

Eh? Why doesn't this fix that?

Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Kevin DuBois (kdub) wrote :

"don't disapprove"... Not quite sure of the debian policies.

review: Abstain
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

I don't think we should be reverting these:

34 +Recommends: mir-doc
...
42 + libmirclient-dev,
43 + libmirserver-dev,

review: Needs Fixing
Revision history for this message
Alexandros Frantzis (afrantzis) wrote :

> I don't think we should be reverting these:

No we shouldn't, I reverted them for testing purposes (since otherwise I wouldn't see the effect of my changes).

Do not top approve.

review: Needs Fixing
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/control'
2--- debian/control 2014-08-07 08:43:25 +0000
3+++ debian/control 2014-08-13 07:04:01 +0000
4@@ -111,8 +111,8 @@
5 Depends: libmircommon1 (= ${binary:Version}),
6 libprotobuf-dev (>= 2.4.1),
7 ${misc:Depends},
8-Breaks: mircommon-dev (<= 0.5.0+14.10.20140722-0ubuntu1)
9-Replaces: mircommon-dev (<= 0.5.0+14.10.20140722-0ubuntu1)
10+Breaks: mircommon-dev (<< 0.6)
11+Replaces: mircommon-dev (<< 0.6)
12 Description: Display server for Ubuntu - development headers
13 Mir is a display server running on linux systems, with a focus on efficiency,
14 robust operation and a well-defined driver model.
15@@ -128,8 +128,8 @@
16 libmircommon-dev,
17 libboost-program-options-dev,
18 ${misc:Depends},
19-Breaks: libmirplatform (<=0.5.1+14.10.20140728-0ubuntu1)
20-Replaces: libmirplatform (<=0.5.1+14.10.20140728-0ubuntu1)
21+Breaks: libmirplatform (<< 0.6)
22+Replaces: libmirplatform (<< 0.6)
23 Description: Display server for Ubuntu - development headers
24 Mir is a display server running on linux systems, with a focus on efficiency,
25 robust operation and a well-defined driver model.

Subscribers

People subscribed via source and target branches