Merge lp:~afrantzis/mir/fix-1514391-mircookie-nettle-dev-dependency into lp:mir

[Alexandros Frantzis]

debian: Fix mircookie-dev package to depend on nettle-dev

debian: Fix mircookie-dev package to depend on nettle-dev

[Andreas Pokorny (andreas-pokorny)]

lgtm

review: Approve

[Alan Griffiths (alan-griffiths)]

I'm unclear why we have "Requires.private: nettle" (which seems to be the reason for needing nettle-dev) - we don't expose dependencies on nettle headers.

Shouldn't everything we need from nettle be provided transitively by libmircookie?

review: Needs Information

[Alexandros Frantzis (afrantzis)]

> Shouldn't everything we need from nettle be provided transitively by libmircookie?

That's a good point. It doesn't seem that Requires.private is needed at all anymore. It is probably a leftover from when cookie_factory.h included <nettle/hmac.h> (which was only for a short while and I am not sure if that version ever hit trunk anyway).

[Andreas Pokorny (andreas-pokorny)]

+!

review: Approve

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:3093
http://jenkins.qa.ubuntu.com/job/mir-ci/5526/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-vivid-i386-build/4832
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-clang-vivid-amd64-build/3739
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-vivid-touch/4774
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-wily-touch/732/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-wily-amd64-ci/1680
        deb: http://jenkins.qa.ubuntu.com/job/mir-wily-amd64-ci/1680/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-wily-i386-ci/732
        deb: http://jenkins.qa.ubuntu.com/job/mir-wily-i386-ci/732/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/4775
        deb: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/4775/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-runner-touch/7375
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/25011
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-wily-armhf/733/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-ci/5526/rebuild

review: Approve (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:3094
http://jenkins.qa.ubuntu.com/job/mir-ci/5528/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-vivid-i386-build/4834
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-clang-vivid-amd64-build/3741
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-vivid-touch/4776
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-wily-touch/734/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-wily-amd64-ci/1682
        deb: http://jenkins.qa.ubuntu.com/job/mir-wily-amd64-ci/1682/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-wily-i386-ci/734
        deb: http://jenkins.qa.ubuntu.com/job/mir-wily-i386-ci/734/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/4777
        deb: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/4777/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-runner-touch/7377
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/25017
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-wily-armhf/735/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-ci/5528/rebuild

review: Approve (continuous-integration)

[Brandon Schaefer (brandontschaefer)]

+1

review: Approve

[Alan Griffiths (alan-griffiths)]

LGTM

review: Approve

=== modified file 'src/cookie/mircookie.pc.in'
--- src/cookie/mircookie.pc.in	2015-09-08 22:54:07 +0000
+++ src/cookie/mircookie.pc.in	2015-11-09 12:25:22 +0000
@@ -6,6 +6,5 @@
 Name: mircookie
 Description: Mir client library
 Version: @MIR_VERSION@
-Requires.private: nettle
 Libs: -L${libdir} -lmircookie
 Cflags: -I${includedir}