Mir

Merge lp:~afrantzis/mir/fix-1514391-mircookie-nettle-dev-dependency into lp:mir

Proposed by Alexandros Frantzis on 2015-11-09
Status: Merged
Approved by: Alan Griffiths on 2015-11-09
Approved revision: 3094
Merged at revision: 3093
Proposed branch: lp:~afrantzis/mir/fix-1514391-mircookie-nettle-dev-dependency
Merge into: lp:mir
Diff against target: 10 lines (+0/-1)
1 file modified
src/cookie/mircookie.pc.in (+0/-1)
To merge this branch: bzr merge lp:~afrantzis/mir/fix-1514391-mircookie-nettle-dev-dependency
Reviewer Review Type Date Requested Status
Alan Griffiths Approve on 2015-11-09
Brandon Schaefer (community) Approve on 2015-11-09
PS Jenkins bot (community) continuous-integration Approve on 2015-11-09
Andreas Pokorny (community) 2015-11-09 Approve on 2015-11-09
Review via email: mp+276982@code.launchpad.net

Commit message

debian: Fix mircookie-dev package to depend on nettle-dev

Description of the change

debian: Fix mircookie-dev package to depend on nettle-dev

To post a comment you must log in.
Andreas Pokorny (andreas-pokorny) wrote :

lgtm

review: Approve
Alan Griffiths (alan-griffiths) wrote :

I'm unclear why we have "Requires.private: nettle" (which seems to be the reason for needing nettle-dev) - we don't expose dependencies on nettle headers.

Shouldn't everything we need from nettle be provided transitively by libmircookie?

review: Needs Information
Alexandros Frantzis (afrantzis) wrote :

> Shouldn't everything we need from nettle be provided transitively by libmircookie?

That's a good point. It doesn't seem that Requires.private is needed at all anymore. It is probably a leftover from when cookie_factory.h included <nettle/hmac.h> (which was only for a short while and I am not sure if that version ever hit trunk anyway).

3094. By Alexandros Frantzis on 2015-11-09

cookie: Remove nettle pkg-config dependency from mircookie.pc

Andreas Pokorny (andreas-pokorny) wrote :

+!

review: Approve
Brandon Schaefer (brandontschaefer) wrote :

+1

review: Approve
Alan Griffiths (alan-griffiths) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/cookie/mircookie.pc.in'
2--- src/cookie/mircookie.pc.in 2015-09-08 22:54:07 +0000
3+++ src/cookie/mircookie.pc.in 2015-11-09 12:25:22 +0000
4@@ -6,6 +6,5 @@
5 Name: mircookie
6 Description: Mir client library
7 Version: @MIR_VERSION@
8-Requires.private: nettle
9 Libs: -L${libdir} -lmircookie
10 Cflags: -I${includedir}

Subscribers

People subscribed via source and target branches