lp:~afrantzis/mir/fix-1317801

Branch merges

Propose for merging

No branches dependent on this one.

Rejected for merging into lp:mir

Alberto Aguirre (community): Needs Fixing on 2014-05-12

Daniel van Vugt: Needs Fixing on 2014-05-12

Alan Griffiths: Abstain on 2014-05-12

PS Jenkins bot (community): Approve (continuous-integration) on 2014-05-09

Diff: 162 lines (+76/-7)

2 files modified

src/server/compositor/buffer_queue.cpp (+17/-0)
tests/unit-tests/compositor/test_buffer_queue.cpp (+59/-7)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1317801: [regression] [BufferQueue] BufferQueueTest.compositor_never_owns_client_buffers occasionally crashes with: what(): unexpected release: buffer was not given to compositor	Critical	Fix Released
Bug #1318632: [regression] [BufferQueue] Race condition in BufferQueue::compositor_acquire could underflow shared_ptr refcount and delete prematurely, crash.	High	Fix Released

Link a bug report

Related blueprints

1618. By Alexandros Frantzis on 2014-05-09

tests: Simplify test

1617. By Alexandros Frantzis on 2014-05-09

tests: Use AutoJoinThread to ensure proper cleanup

1616. By Alexandros Frantzis on 2014-05-09

compositor: Fix race in BufferQueue

1615. By Alan Griffiths on 2014-05-09

frontend, client: sort out the "wiring" to allow trusted helpers to get a connected FD to pass to clients.

Approved by Nick Dedekind, PS Jenkins bot, Alexandros Frantzis, Alberto Aguirre.

1614. By Daniel van Vugt on 2014-05-09

Move resize clamping responsibility out of the demo-shell and into the
server library.

Clamping is very important in interactive surface resizing as input events
are rarely perfectly proportioned to hit the actual minimum size exactly. They
usually overshoot. So the shell/server has some responsibility to correct
this. The alternative is to treat it as an error and resize nothing, which
results in a very frustrating user experience; not acceptable.

But moving the clamping out of demo-shell into the server doesn't just
reduce redundancy. With the future introduction of window decorations and
other size-limiting semantics, the shell can't feasibly know in advance what
is a "valid size". It simply has to attempt a resize and let Mir find the best
fit that works with the decorations and other surface sizing rules.

Approved by PS Jenkins bot, Robert Carr, Alexandros Frantzis, Alberto Aguirre.

1613. By Daniel van Vugt on 2014-05-09

Clarify size/position interfaces in the Surface classes to be less ambiguous
when it comes to more advanced (future) behaviour such as window frames
and decoration.

This initial work just clarifies the interfaces by renaming functions. The
related behavioural changes will come later.

The new naming scheme is:
   size(), top_left() - Describes the whole surface (window) including
                        frame/titlebar (if any).
   client_size() - Describes the size of the client rectangle within the
                        window (note position is not implemented yet).
   input_*() - Input coordinate testing.
.

Approved by Robert Carr, Alexandros Frantzis, Alberto Aguirre, PS Jenkins bot, Alan Griffiths.

1612. By Andreas Pokorny on 2014-05-08

Move InputDispatcherConfiguration as a new entity into the DisplayServer

This makes the InputManager only responsible for controlling the parts that are responsible for
receiving the user input. This is the first preparation step for renaming InputConfigurartion
into InputReceiverConifugration and for making a split of InputDispatcherConfiguration and
the InputConfiguration possible.

Approved by PS Jenkins bot, Alexandros Frantzis, Alan Griffiths, Chris Halse Rogers.

1611. By Andreas Pokorny on 2014-05-08

Adds two further input dispatcher methods to inform about device resets and configration changes

The interface of those two methods is based on what is currently provided by the android notification
classes. The android input stack uses these two methods to clear input queues.

Approved by PS Jenkins bot, Alan Griffiths, Alexandros Frantzis, Robert Carr.

1610. By Daniel van Vugt on 2014-05-08

examples: Update FIXME comments around MirMotionAction issues to point to the
correct bug: https://bugs.launchpad.net/mir/+bug/1311699
.

Approved by Alan Griffiths, PS Jenkins bot.

1609. By Alberto Aguirre on 2014-05-08

GLProgram should be part of platform/graphics (LP: #1317200). Fixes: https://bugs.launchpad.net/bugs/1317200.

Approved by Alan Griffiths, Daniel van Vugt, PS Jenkins bot.