lp:~afrantzis/mir/consume-only-not-rendered-buffers

Branch merges

Propose for merging

No branches dependent on this one.

Rejected for merging into lp:mir

PS Jenkins bot (community): Approve (continuous-integration) on 2014-04-23

Daniel van Vugt: Needs Fixing on 2014-04-23

Kevin DuBois (community): Needs Fixing on 2014-04-22

Alan Griffiths: Needs Information on 2014-04-22

Diff: 365 lines (+82/-31)

11 files modified

examples/render_overlays.cpp (+11/-1)
include/platform/mir/graphics/renderable.h (+2/-0)
include/test/mir_test_doubles/fake_renderable.h (+10/-1)
include/test/mir_test_doubles/mock_renderable.h (+1/-0)
include/test/mir_test_doubles/stub_renderable.h (+13/-0)
src/server/compositor/multi_threaded_compositor.cpp (+23/-27)
src/server/scene/basic_surface.cpp (+8/-0)
src/server/scene/basic_surface.h (+3/-0)
src/server/scene/surface_stack.cpp (+3/-0)
tests/unit-tests/compositor/test_multi_threaded_compositor.cpp (+2/-2)
tests/unit-tests/graphics/android/test_hwc_device.cpp (+6/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1308843: [regression] [nonblockswap] Client judders, skipping frames periodically	High	Fix Released
Bug #1308844: [regression] [nonblockswap] BufferConsumingFunctor holds buffers too long, potentially hurting client render throughput	Medium	Fix Released

Link a bug report

Related blueprints

1569. By Alexandros Frantzis on 2014-04-23

tests: Fix android build

1568. By Alexandros Frantzis on 2014-04-22

compositor: Only consume buffers that have not been rendered recently to unblock client eglSwapBuffers

1567. By Daniel van Vugt on 2014-04-22

Move saved_resources into GLRenderer, which is more logical since the
requirement to save resources is a GL one, and it simplifies parameters
too.
.

Approved by Daniel van Vugt, PS Jenkins bot, Alberto Aguirre, Kevin DuBois.

1566. By Kevin DuBois on 2014-04-18

remove dead mock file.

Approved by Robert Carr, PS Jenkins bot.

1565. By Alan Griffiths on 2014-04-18

shell, scene put surface_creation_parameters.cpp where it belongs.

Approved by Kevin DuBois, Robert Carr, PS Jenkins bot, Alberto Aguirre.

1564. By Daniel van Vugt on 2014-04-17

test_gl_renderer.cpp: Remove dead code. The "renderer" member variable is
now unused and masked by local variables of the same name. This also makes
the cleanup/ordering logic unnecessary.

Approved by Alberto Aguirre, Alan Griffiths, Alexandros Frantzis, PS Jenkins bot.

1563. By Colin Watson on 2014-04-17

Fix packaging failure on arm64.

Approved by Daniel van Vugt, Alexandros Frantzis, Chris Halse Rogers, PS Jenkins bot.

1562. By Daniel van Vugt on 2014-04-17

First attempt at shrinking the docs. For me, this reduces the expanded
size from 119M to 65M. And 11M compressed (from 56M). (LP: #1304998). Fixes: https://bugs.launchpad.net/bugs/1304998.

Approved by Kevin DuBois, Robert Carr, Andreas Pokorny, PS Jenkins bot.

1561. By Kevin DuBois on 2014-04-17

When looking at the compositor code, I noticed two chunks of code that could be changed without making the tests fail.
Write an integration test that catches those interactions (among other common interactions between the SurfaceStack and compositor system) if they're changed. The tests check that the displaybuffer is posted at least a given number of times before a timeout. This is a multithreaded system, so the tests are designed to pass quickly (they fail on 5s timeout).

Approved by PS Jenkins bot, Andreas Pokorny, Alan Griffiths.

1560. By Alberto Aguirre on 2014-04-16

Remove stale socket files (LP: #1285215)

Stale socket files can be detected by checking the active socket connection table
at /proc/net/unix.
Stale socket files are files that exist, are of socket type
but don't have an active socket connection entry. Fixes: https://bugs.launchpad.net/bugs/1285215.

Approved by PS Jenkins bot, Alexandros Frantzis, Robert Carr, Alan Griffiths.