Merge lp:~afrantzis/mir/client-api-platform-operation-fds into lp:mir

[Alexandros Frantzis]

client: Add fd support to MirPlatformMessage

client: Add fd support to MirPlatformMessage

[Kevin DuBois (kdub)]

LGTM,

comment on a pre-existing issue, but
185 + repeated sint32 fd = 3;

Forces us to strip the ownership info of the FD's at a point before the ipc-processing code is dispatched with the message. I guess this is the price to pay for having SessionMediator inherit from the protobuf-generated stub, but it would be nice to have mir:Fd make it to the ipc-code and not have to deal with resource caches.

review: Approve

[Cemil Azizoglu (cemil-azizoglu)]

LGTM.

review: Approve

[Alan Griffiths (alan-griffiths)]

36 + * The fd array is copied into the message, but the message does not take
37 + * ownership of the fds themselves.

When is it safe for the client code to close the FDs?

Also, we know what "take ownership" means, but is it clear in the C world?

review: Needs Fixing

[Alexandros Frantzis (afrantzis)]

Updated docs.

> When is it safe for the client code to close the FDs?

From the new docs:

"the caller is responsible for keeping the fds open for as long as this message needs to remain valid"

How long is long enough depends on the context. For example, for mir_connection_platform_operation() call:

"The MirPlatformMessage used for the request needs to remain valid until this operation finishes"

[Alan Griffiths (alan-griffiths)]

OK

(I don't have a factual basis on which to decide whether leaving the client with "ownership" of the FDs is the correct choice.)

review: Approve

[Daniel van Vugt (vanvugt)]

Landed and then reverted. Parent branch needs fixing.

[Daniel van Vugt (vanvugt)]

review: Needs Fixing

[lp:~afrantzis/mir/client-api-platform-operation-fds]

2125. By Alexandros Frantzis on 2014-12-10

Sync with parent branch

[Alexandros Frantzis (afrantzis)]

A merge of this branch in trunk followed by a revert has confused bzr. Rejecting this branch and resubmitting this code as part of:

https://code.launchpad.net/~afrantzis/mir/client-api-platform-operation/+merge/244272

Unmerged revisions

2125. By Alexandros Frantzis on 2014-12-10

Sync with parent branch