Mir

Merge lp:~afrantzis/mir/ci-failure-experiment-1 into lp:mir

  1. ci-failure-experiment-1
  2. Merge into development-branch
Proposed by Alexandros Frantzis
Status: Rejected
Rejected by: Alexandros Frantzis
Proposed branch: lp:~afrantzis/mir/ci-failure-experiment-1
Merge into: lp:mir
Diff against target: 16 lines (+2/-2)
1 file modified
src/platforms/android/server/android_buffer_allocator.cpp (+2/-2)
To merge this branch: bzr merge lp:~afrantzis/mir/ci-failure-experiment-1
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Alexandros Frantzis (community) Disapprove
Review via email: mp+278344@code.launchpad.net

Commit message

DO NOT MERGE, experimental

android: Don't close the gralloc device

Description of the change

DO NOT MERGE, experimental

android: Don't close the gralloc device

To post a comment you must log in.
Revision history for this message
Alexandros Frantzis (afrantzis) :
review: Disapprove
lp:~afrantzis/mir/ci-failure-experiment-1 updated
3123. By Alexandros Frantzis

Avoid build error

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:3122
http://jenkins.qa.ubuntu.com/job/mir-ci/5637/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-android-vivid-i386-build/4998/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-clang-vivid-amd64-build/3905/console
    None: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-vivid-touch/4945/console
    None: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-wily-touch/900/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-wily-amd64-ci/1790/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-wily-i386-ci/898/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/4945/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-wily-armhf/902/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-ci/5637/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:3123
http://jenkins.qa.ubuntu.com/job/mir-ci/5642/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-vivid-i386-build/5003
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-clang-vivid-amd64-build/3909
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-vivid-touch/4949/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-wily-touch/905/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-wily-amd64-ci/1795
        deb: http://jenkins.qa.ubuntu.com/job/mir-wily-amd64-ci/1795/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-wily-i386-ci/903
        deb: http://jenkins.qa.ubuntu.com/job/mir-wily-i386-ci/903/artifact/work/output/*zip*/output.zip
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/4949/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-wily-armhf/906/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-ci/5642/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:3123
http://jenkins.qa.ubuntu.com/job/mir-ci/5652/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-vivid-i386-build/5013
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-clang-vivid-amd64-build/3919
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-vivid-touch/4959
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-wily-touch/915/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-wily-amd64-ci/1805
        deb: http://jenkins.qa.ubuntu.com/job/mir-wily-amd64-ci/1805/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-wily-i386-ci/913
        deb: http://jenkins.qa.ubuntu.com/job/mir-wily-i386-ci/913/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/4959
        deb: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/4959/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-runner-touch/7505
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/25463
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-wily-armhf/916/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-ci/5652/rebuild

review: Approve (continuous-integration)

Unmerged revisions

3123. By Alexandros Frantzis

Avoid build error

3122. By Alexandros Frantzis

Don't close the gralloc device

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/platforms/android/server/android_buffer_allocator.cpp'
2--- src/platforms/android/server/android_buffer_allocator.cpp 2015-08-07 15:55:22 +0000
3+++ src/platforms/android/server/android_buffer_allocator.cpp 2015-11-23 17:10:59 +0000
4@@ -38,10 +38,10 @@
5 {
6 struct AllocDevDeleter
7 {
8- void operator()(alloc_device_t* t)
9+ void operator()(alloc_device_t* /*t*/)
10 {
11 /* android takes care of delete for us */
12- t->common.close((hw_device_t*)t);
13+ //t->common.close((hw_device_t*)t);
14 }
15 };
16 }

Subscribers

People subscribed via source and target branches