Merge lp:~aelkner/schooltool/schooltool.intervention_august_fixes into lp:~schooltool-owners/schooltool/schooltool.intervention

Proposed by Alan Elkner
Status: Merged
Merged at revision: 167
Proposed branch: lp:~aelkner/schooltool/schooltool.intervention_august_fixes
Merge into: lp:~schooltool-owners/schooltool/schooltool.intervention
Diff against target: None lines
To merge this branch: bzr merge lp:~aelkner/schooltool/schooltool.intervention_august_fixes
Reviewer Review Type Date Requested Status
Gediminas Paulauskas Pending
Review via email: mp+10712@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Gediminas Paulauskas (menesis) wrote :

In fact it was merged to lp:schooltool.intervention

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/schooltool/intervention/browser/README.txt'
2--- src/schooltool/intervention/browser/README.txt 2009-07-23 04:51:31 +0000
3+++ src/schooltool/intervention/browser/README.txt 2009-08-25 22:36:56 +0000
4@@ -762,7 +762,6 @@
5 >>> print manager.contents
6 <BLANKLINE>
7 ...course1 - section1's Student Interventions...
8- ...Intervention...
9 <p>Messages</p> ...
10 <a ...Goals</a> ...
11 ...Student1 Student1...
12@@ -778,7 +777,6 @@
13 >>> print manager.contents
14 <BLANKLINE>
15 ...course1 - section1's Student Interventions...
16- ...Intervention...
17 <a ...Messages</a> ...
18 <p>Goals</p> ...
19 ...Student1 Student1...
20
21=== modified file 'src/schooltool/intervention/browser/intervention.pt'
22--- src/schooltool/intervention/browser/intervention.pt 2009-07-29 04:50:33 +0000
23+++ src/schooltool/intervention/browser/intervention.pt 2009-08-25 23:52:33 +0000
24@@ -89,16 +89,21 @@
25 <br />
26 <fieldset>
27 <legend><b>Report Sheets</b><legend>
28- <tal:if condition="not: view/sheets">
29+ <tal:if condition="not: view/terms">
30 <ul><li>There are none.<br /></li></ul>
31 </tal:if>
32- <tal:if condition="view/sheets">
33+ <tal:if condition="view/terms">
34 <ul>
35- <li tal:repeat="sheet view/sheets">
36- <a href="" tal:content="sheet/text"
37- tal:attributes="href sheet/url">
38- Report Sheet
39- </a>
40+ <li tal:repeat="term view/terms">
41+ <span tal:content="term/title" />
42+ <ul>
43+ <li tal:repeat="sheet term/sheets">
44+ <a href="" tal:content="sheet/text"
45+ tal:attributes="href sheet/url">
46+ Report Sheet
47+ </a>
48+ </li>
49+ </ul>
50 </li>
51 </ul>
52 </tal:if>
53
54=== modified file 'src/schooltool/intervention/browser/intervention.py'
55--- src/schooltool/intervention/browser/intervention.py 2009-07-29 09:33:38 +0000
56+++ src/schooltool/intervention/browser/intervention.py 2009-08-26 02:50:06 +0000
57@@ -218,12 +218,13 @@
58 self.newGoalURL = interventionURL + '/goals/+/addGoal.html'
59 self.allGoalsURL = interventionURL + '/goals/allGoals.html'
60
61- self.sheets = []
62 studentId = self.context.student.username
63 currentYear = ISchoolYear(self.context.__parent__)
64+ terms = {}
65 for section in self.learnerOf():
66 if ISchoolYear(ITerm(section)) != currentYear:
67 continue
68+ sheets = terms.setdefault(ITerm(section), [])
69 for worksheet in IActivities(section).values():
70 if not worksheet.deployed:
71 continue
72@@ -236,7 +237,9 @@
73 studentId),
74 'text': title
75 }
76- self.sheets.append(sheet)
77+ sheets.append(sheet)
78+ self.terms = [{'title': term.title, 'sheets': terms[term]}
79+ for term in sorted(terms.keys())]
80
81 self.statusMessages = []
82 for k, v in sorted(self.context['messages'].items()):
83@@ -296,12 +299,15 @@
84
85 def reportSheetLinks(self, student):
86 studentId = student.__name__
87+ nexturl = absoluteURL(self.context, self.request) + \
88+ '/@@interventions.html'
89 results = []
90 for worksheet in self.worksheets:
91 worksheet_url = absoluteURL(worksheet, self.request)
92 result = {
93 'title': worksheet.title,
94- 'url': '%s/gradebook/%s' % (worksheet_url, studentId)
95+ 'url': '%s/gradebook/%s?nexturl=%s' % (worksheet_url,
96+ studentId, nexturl)
97 }
98 results.append(result)
99 return results
100
101=== modified file 'src/schooltool/intervention/browser/section_interventions.pt'
102--- src/schooltool/intervention/browser/section_interventions.pt 2009-01-05 12:53:51 +0000
103+++ src/schooltool/intervention/browser/section_interventions.pt 2009-08-25 22:36:56 +0000
104@@ -22,7 +22,7 @@
105 <table class="students_nav">
106
107 <tr>
108- <th>Intervention</th>
109+ <th />
110 <th>
111 <tal:block tal:repeat="tab view/iterTabs">
112 <tal:block condition="tab/active">

Subscribers

People subscribed via source and target branches